fix: recognize Kubernetes CRD schema as builtin - #1311
Open
Pybsama wants to merge 1 commit into
Open
Conversation
Contributor
|
This seems to be the right direction. @shin19991207 may have also started something, I don't know for sure though. |
Member
|
@datho7561 Yes, this seems to be the right direction. And I haven't started anything on this so please feel free to start reviewing on this PR! |
datho7561
approved these changes
Jul 31, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good and works well! Thanks for the contribution! Is there anything else that needs to be done on here?
Pybsama
marked this pull request as ready for review
August 3, 2026 04:53
Use the Kubernetes schema generator's apiextensions-apiserver prefix for the official apiextensions.k8s.io group. Keep unsupported native versions on all.json instead of falling back to the external CRD catalog. Fixes redhat-developer#1310 Signed-off-by: sama Pyb <peiyibopybsama@gmail.com>
datho7561
force-pushed
the
codex/recognize-native-crd-schema
branch
from
August 6, 2026 18:42
c40b51e to
14f99a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Kubernetes publishes
CustomResourceDefinitionunder theio.k8s.apiextensions-apiserver.pkg.apisdefinition prefix rather than theusual
io.k8s.apiprefix. The current exact matcher therefore misses thisbuiltin resource and falls back to a nonexistent entry in the external CRD
catalog.
This change:
apiextensions.k8s.ioAPI group to its generated Kubernetesdefinition prefix;
io.k8s.apimatching behavior for every othergroup;
all.jsonwhen an apiextensions kind or version is absent fromthe selected Kubernetes schema instead of treating it as a custom resource;
What issues does this PR fix or reference?
Fixes #1310
Is it tested? How?
npm run buildThe full suite currently has one unrelated live SchemaStore assertion for the
Drone schema. It reproduces unchanged on the exact
mainbase commit becausethe externally served diagnostic ordering no longer matches the fixture; the
1,305 remaining tests pass under Node.js 22.
AI assistance was used during implementation and review; I verified the
changes and all reported test results.