Fix schema priority lookup for normalized file URIs - #1312
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
4 tasks
datho7561
approved these changes
Jul 31, 2026
datho7561
left a comment
Contributor
There was a problem hiding this comment.
I confirmed that overriding the schema with an encoded colon causes it to not be used when there's two schemas assgined to a file, and that this fixes that.
I'll play around with it on Windows too to see if I can replicate that problem and if this fixes it. Do you want to merge this as-is, or wait to hear back from phaumer?
Member
Author
|
@datho7561 I think this PR can be merged as-is. I'll open another PR for the original reported issue when we can actually reproduce and identify the issue. |
Contributor
|
Sounds good, let's merge, then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before the fix, schema registration normalizes URIs to skip encodings, however, schema priorities were stored using the original URI. For an encoded Windows file URI, this produced different keys:
As a result, the configured schema's priority could not be found and defaulted to
0. Another matching schema could then incorrectly take precedence over the schema configured throughyaml.schemas.This PR normalizes URIs consistently when recording schema priorities, ensuring encoded and unencoded forms of the same URI use the same key.
What issues does this PR fix or reference?
Related to redhat-developer/vscode-yaml#1274
Is it tested? How?
test.yamlto be validated againstMultiple JSON Schemas(bothencoded:schema.jsonandschema.json), instead of justschema.json.