Add warning when optimize_query is used with non-semantic search modes. - #355
Open
Zekward wants to merge 3 commits into
Open
Add warning when optimize_query is used with non-semantic search modes.#355Zekward wants to merge 3 commits into
Zekward wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5fd396c. Configure here.
- Logs warning if optimize_query=True but search_mode is KEYWORD or HYBRID - addresses issue redis#252 (option 4)
When SummaryView is deleted, remove all associated computed partition summaries using SCAN to find matching keys. Fix redis#229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

optimize_queryonly applies to semantic search, consider supporting keyword and hybrid modes #252 (option 4)Note
Low Risk
Observability-only change in search path; no change to query handling or search results.
Overview
When
optimize_query=Trueis passed tosearch_long_term_memoriesbutsearch_modeis not semantic (keyword or hybrid), the server now emits alogger.warningstating that query optimization applies only to semantic search.Behavior is unchanged: lexical modes still use the original query text; only semantic search may call
optimize_query_for_vector_search. The warning helps callers who enable optimization globally or via APIs that do not vary by mode (issue #252).Reviewed by Cursor Bugbot for commit 2ecf0fd. Bugbot is set up for automated code reviews on this repo. Configure here.