Skip to content

Add warning when optimize_query is used with non-semantic search modes. - #355

Open
Zekward wants to merge 3 commits into
redis:mainfrom
Zekward:main
Open

Add warning when optimize_query is used with non-semantic search modes.#355
Zekward wants to merge 3 commits into
redis:mainfrom
Zekward:main

Conversation

@Zekward

@Zekward Zekward commented Aug 10, 2026

Copy link
Copy Markdown

Note

Low Risk
Observability-only change in search path; no change to query handling or search results.

Overview
When optimize_query=True is passed to search_long_term_memories but search_mode is not semantic (keyword or hybrid), the server now emits a logger.warning stating that query optimization applies only to semantic search.

Behavior is unchanged: lexical modes still use the original query text; only semantic search may call optimize_query_for_vector_search. The warning helps callers who enable optimization globally or via APIs that do not vary by mode (issue #252).

Reviewed by Cursor Bugbot for commit 2ecf0fd. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5fd396c. Configure here.

Comment thread V0/agent_memory_server/long_term_memory.py Outdated
Comment thread V0/agent_memory_server/long_term_memory.py
- Logs warning if optimize_query=True but search_mode is KEYWORD or HYBRID
- addresses issue redis#252 (option 4)
When SummaryView is deleted, remove all associated computed partition summaries using SCAN to find matching keys.

Fix redis#229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant