Skip to content

Add warning when optimize_query is used with non-semantic search modes. #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zekward wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Add warning when optimize_query is used with non-semantic search modes. #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions V0/agent_memory_server/long_term_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,10 @@ async def search_long_term_memories(
# preserve the literal text for lexical matching.
search_query = text
optimized_applied = False

if optimize_query and search_mode != SearchModeEnum.SEMANTIC:
logger.warning(f"optimize_query=True is only supported for semantic search, but search_mode='{search_mode.value}'")

if optimize_query and text and search_mode == SearchModeEnum.SEMANTIC:
search_query = await optimize_query_for_vector_search(text)
optimized_applied = True
Expand Down