Skip to content

Clean up orphaned partition summaries when deleting summary views #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zekward wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Clean up orphaned partition summaries when deleting summary views #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions V0/agent_memory_server/summary_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,23 @@ async def delete_summary_view(view_id: str) -> None:
up in a later pass if needed.
"""

cursor = 0

redis = await get_redis_conn()
await redis.delete(_config_key(view_id))
await redis.srem(_SUMMARY_VIEW_INDEX_KEY, view_id)

pattern = _summary_key(view_id, "*")

while True:
cursor, keys = await redis.scan(cursor=cursor, match=pattern, count=100)

for key in keys:
await redis.delete(key)

if cursor == 0:
break

@cursor cursor Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh recreates deleted summaries

Medium Severity

Deleting a view only cleans summary keys present during the SCAN. An in-flight refresh_summary_view that already loaded the view can keep calling save_partition_result afterward and recreate summary_view:{view_id}:summary:* keys with no config left, reintroducing the orphaned Redis data this change aims to remove. The race window is large because partition summarization can run for minutes.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 06a7ba7. Configure here.



async def save_partition_result(result: SummaryViewPartitionResult) -> None:
"""Persist a single partition result for a SummaryView."""
Expand Down