Video and audio combined download#545
Open
ac615223s5 wants to merge 4 commits into
Open
Conversation
Reddit has transitioned from DASH to CMAF video format. This change adds
support for both formats to maintain compatibility.
Changes:
- Update REGEX_URL_VIDEOS to match both DASH and CMAF formats
- Add format capture group to preserve DASH/CMAF in URL path
- Add separate proxy endpoints for /vid/:id/dash/:size and /vid/:id/cmaf/:size
- Update format_url to handle 3-segment video URLs (id/format/size)
- Update tests to reflect new URL format with format segment
Video URLs now follow pattern: /vid/{id}/{format}/{size}.mp4
Example: /vid/abc123/cmaf/720.mp4
fix(video): add support for CMAF video format alongside DASH
|
Wow, I just thought of this idea and it looks like you already came up with the solid solution of using ffmpeg directly in the browser to combine audio and video! Sadly it doesn't work for me, also, you can't realistically expect the maintainers to approve a PR failing all tests and using a random opaque WASM binary tbh |
Contributor
Author
|
The upstream already fails the tests. I can't help you with your instance given the limited information, but it usually takes a few seconds to process for me. I am running https://github.com/ac615223s5/redlib/tree/main. The maintainers should source the library files themselves or use something like npm or jsdelivr. It's not really my decision |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #105
requires #506
uses the library https://github.com/ffmpegwasm/ffmpeg.wasm
if there is another preferred way to include this library (such as npm), feel free to fork my fork.