fix(ci): tag from whatever branch the repo calls its trunk - #13
Merged
Conversation
deploy.yaml fired on a hardcoded `master`, so it never ran in the personaclick
mirror, whose default branch is `main` — no tag was ever pushed there and
publish.yaml, which triggers on tags, never got a chance to publish.
`on:` cannot express this: it takes literal branch names and does not evaluate
${{ }}. So the workflow now starts on any branch push and the trunk check moves
into the job, where expressions do work. Pushes to other branches start the run
and stop at the `if`, which GitHub reports as conclusion "skipped" — not
"success" — so sync.yaml's workflow_run gate stays untouched.
Tag pushes are excluded by '**', which matches branches only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.yaml fired on a hardcoded
master, so it never ran in the personaclick mirror, whose default branch ismain— no tag was ever pushed there and publish.yaml, which triggers on tags, never got a chance to publish.on:cannot express this: it takes literal branch names and does not evaluate ${{ }}. So the workflow now starts on any branch push and the trunk check moves into the job, where expressions do work. Pushes to other branches start the run and stop at theif, which GitHub reports as conclusion "skipped" — not "success" — so sync.yaml's workflow_run gate stays untouched.Tag pushes are excluded by '**', which matches branches only.