Fix setAmxString cutting off the last character of strings#384
Closed
metita wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
closing in favor of #385, same fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383
Since 3c08fde setAmxString treats max as the full buffer size including the null terminator, but plugins pass charsmax(buffer) which already excludes it. So every native that returns a string (get_entvar, get_member, etc.) was losing the last character.
This restores the old behavior (copy up to max chars, terminator goes at dest[max]) and keeps the null pointer check.