Skip to content

Changes to support building on OTP 28#42

Merged
jessestimpson merged 4 commits intomasterfrom
upgrade-cowboy-for-otp-28-build
May 4, 2026
Merged

Changes to support building on OTP 28#42
jessestimpson merged 4 commits intomasterfrom
upgrade-cowboy-for-otp-28-build

Conversation

@jessestimpson
Copy link
Copy Markdown
Member

@jessestimpson jessestimpson commented May 4, 2026

  • Fix malformed eunit test instantiators. Many tests were not actually being asserted on.
  • Fix exemplar encoding to avoid unnecessary string allocations
  • Sort tag and labels for consistent ordering for testability and reproducibility in general.
  • Upgrade cowboy to fix build errors on OTP 28

@jessestimpson jessestimpson changed the title Fix malformed eunit test instantiators Changes to support building on OTP 28 May 4, 2026
@jessestimpson jessestimpson requested a review from weaversam8 May 4, 2026 13:13
Copy link
Copy Markdown
Member

@weaversam8 weaversam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change, this otherwise looks great

Comment thread src/openmetrics.erl Outdated
Co-authored-by: Sam Weaver <weaversam8@users.noreply.github.com>
@jessestimpson jessestimpson merged commit 3b0543e into master May 4, 2026
2 checks passed
@jessestimpson jessestimpson deleted the upgrade-cowboy-for-otp-28-build branch May 4, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants