Skip to content

Expand and clarify fee structure documentation#337

Merged
pedromcunha merged 23 commits into
mainfrom
claude/awesome-carson-2v7gwp
Jun 12, 2026
Merged

Expand and clarify fee structure documentation#337
pedromcunha merged 23 commits into
mainfrom
claude/awesome-carson-2v7gwp

Conversation

@vezzabel

Copy link
Copy Markdown
Collaborator

Summary

Significantly expanded and reorganized the fee structure documentation to provide clearer explanations of how Relay's fees work, added detailed revenue share information for API customers, and improved the categorization of different transaction types.

Key Changes

  • Restructured fee categories: Renamed "Relay Fees" section title to "Fee Structure" and clarified that fees apply to "token swap or bridge powered by Relay"

  • Enhanced Execution Fees explanation:

    • Clarified the three components: $0.02 flat fee, destination gas estimate, and origin gas estimate (gasless only)
    • Added explicit note that regular transaction users pay origin gas directly to the network, not through Relay
  • Improved Swap Fees section: Added note about Hyperliquid's $1 activation fee that is passed through to users

  • Expanded Relay Fees documentation:

    • Split into two tables: one showing standard fees charged to end users, and a new table showing revenue share percentages for qualified API customers
    • Added qualification requirements: API key, KYB verification, $10M+ volume threshold, and EVM wallet address
    • Clarified that revenue share cannot be used to discount the product to end users
  • Enhanced fee category definitions:

    • Added "Same-chain wrap/unwrap" as a distinct category with examples (ETH↔WETH, SOL↔WSOL, etc.)
    • Expanded stablecoin list to include: USDC.e, USDT0, USD1, PYUSD, USDG, mUSD, USDm, USDH, pUSD, PlumeUSD
    • Added PLUME to major token swaps list
    • Provided concrete examples for each category
    • Improved formatting and clarity of category descriptions
  • Minor formatting improvements: Fixed trailing whitespace and improved markdown consistency

Notable Details

The documentation now clearly distinguishes between end-user fees and revenue share opportunities for API customers, with explicit qualification criteria and volume-based tiers. The expanded token lists and examples make it easier for users to determine which fee category applies to their transactions.

https://claude.ai/code/session_01JQ8XT6661N4WzF4Q7vt8WF

- Rename page title to "Fee Structure" with updated description
- Restructure Execution Fees bullets to clarify gasless vs non-gasless origin gas
- Add Hyperliquid $1 activation fee note to Swap Fees
- Replace volume-tiered effective fee table with standard fees table + revenue share model
- Add eligibility criteria for revenue share program
- Add new Same-Chain Wrap/Unwrap fee category
- Expand stablecoin list (USDC.e, USDT0, USD1, PYUSD, USDG, mUSD, USDm, USDH, pUSD, PlumeUSD)
- Add PLUME to Major token swaps
- Add concrete examples to each fee category

https://claude.ai/code/session_01JQ8XT6661N4WzF4Q7vt8WF
@mintlify

mintlify Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jun 11, 2026, 10:36 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 29s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Post review feedback

Overall this is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / destination gas / origin-gas-for-gasless) is much clearer, the category definitions with concrete examples are a real improvement, and the new revenue-share framing is explicit about qualification and that it can't be used to discount end users.

Math verification (✅ passes): The restructure splits the old per-tier absolute-fee table into a single standard fee + a revenue-share percentage. I checked that the two reconcile with the previous numbers:

Pair Standard Rev share ($10M–$100M) Net Old value
Stablecoin 0.01% 34% → ×0.66 0.0066% 0.0066% ✓
Major 0.06% 25% → ×0.75 0.045% 0.045% ✓
Minor 0.15% 33.33% → ×0.6667 0.10% 0.10% ✓

The $100M–$1B tier (67% / 50% / 66.67%) reconciles the same way to the old 0.0033% / 0.03% / 0.05%. Internally consistent.


Suggestions

1. Same-chain wrap/unwrap is missing from the Standard Fees table (clarity)
The new wrap/unwrap category is listed in the definitions and grouped under "Token Bridge & Same-Chain Wrap/Unwrap" in the revenue-share table (line 64), but the Standard Fees table header (line 34) only says "Token Bridge". A reader can't tell what standard fee applies to a wrap/unwrap. Recommend making the two table headers consistent so the mapping is unambiguous.

Fix this →

2. Inconsistent chain naming: "BNB Chain" vs "Binance Smart Chain" (terminology)
Line 97 uses BNB to WBNB on BNB Chain while line 106 uses AVAX on Avalanche to Aster on Binance Smart Chain. These are the same network — pick one (per §5 of AGENTS.md, prefer the current canonical name "BNB Chain"). Note: "BNB Chain" isn't yet in the §5 canonical chain-names list, so this may be worth adding there too.

Fix this →

3. "Note:" written as plain prose instead of a callout (style, §2.5)
The Hyperliquid note (line 24) uses a bare Note: prefix. AGENTS.md §2.5 reserves <Note>/<Info> components for this. It's nested inside a numbered list item, where MDX callouts can render awkwardly, so this is a judgment call — but worth considering an <Info> for consistency with the rest of the docs.

4. Frontmatter description plural (nit)
description: "Learn about Relay's fee structures" (line 3) — "structures" plural reads slightly oddly against the singular title "Fee Structure". Consider "Learn how Relay's fees work" or "...fee structure".


Minor / non-blocking

  • The Standard Fees table now has a single data row with a label cell ("Relay Fee charged to end users") under a "Standard Fees" header. It renders fine, but a one-row table is a slightly unusual structure — acceptable as-is.
  • The PR description mentions fixing trailing whitespace; line 155 still has a trailing space, though it's outside the diff scope.

None of these are blocking. The content is accurate and the math is sound — items 1 and 2 are the most worth addressing before merge.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 39s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Post review feedback

Re-reviewing after the latest push. The most recent commit (Fix Standard Fees table header to match revenue share table) resolves the prior Suggestion #1 — both fee tables now share the Token Bridge & Same-Chain Wrap/Unwrap header (lines 34 and 64), so the standard fee for a wrap/unwrap is now unambiguous. ✅

This is a solid rewrite overall. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) is much clearer, the explicit "regular users pay origin gas directly to the network" note removes a common misconception, and the category definitions with concrete examples are a genuine improvement.

Math verification (✅ passes): The standard fee × (1 − revenue-share %) reconciles exactly to the old per-tier absolute fees:

Pair Standard $10M–$100M Net Old $100M–$1B Net Old
Stablecoin 0.01% 34% 0.0066% 0.0066% ✓ 67% 0.0033% 0.0033% ✓
Major 0.06% 25% 0.045% 0.045% ✓ 50% 0.03% 0.03% ✓
Minor 0.15% 33.33% 0.10% 0.10% ✓ 66.67% 0.05% 0.05% ✓

Internally consistent.


Still open from the prior review

1. Inconsistent chain naming: "BNB Chain" vs "Binance Smart Chain" (terminology, §5)
Line 97 uses BNB to WBNB on BNB Chain while line 106 uses ...Aster on Binance Smart Chain. Same network — standardize on one. "BNB Chain" is the current canonical name, and per §5 of AGENTS.md it's worth adding to the canonical chain-names list since it isn't there yet.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5)
The Hyperliquid note (line 24) still uses a bare Note: prefix. §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — flagging for consistency, non-blocking.

3. Frontmatter description plural (nit, §2.1)
description: "Learn about Relay's fee structures" (line 3) — "structures" plural reads oddly against the singular title "Fee Structure". Consider "Learn how Relay's fees work".

Fix this →


New observation

4. "major stablecoin" is undefined (clarity)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but the term major stablecoin isn't defined anywhere on the page — there's only the single 15-token "Stablecoin swaps" list (line 98). The previous version named them explicitly (USDT, DAI, USDe, USDs). A reader can't tell whether "major stablecoin" means all 15 listed stablecoins or a subset. Recommend either dropping "major" (so it reads "any major token and any stablecoin") or defining the subset.

Fix this →

Minor / non-blocking

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — pre-existing, outside the diff, but worth a quick fix while here (e.g. "added on top of a Relay quote").
  • Line 155 still has trailing whitespace, despite the PR description noting trailing-whitespace cleanup. Outside the diff scope.

None of these are blocking — the content is accurate and the math is sound. Item 1 (chain naming) and item 4 (undefined "major stablecoin") are the most worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 15s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Post review feedback

Re-reviewing after the latest commits. This is a solid, well-structured rewrite — the Execution Fees breakdown, the category definitions with concrete examples, and the explicit revenue-share framing all read clearly.

Previously-flagged items now resolved ✅

  • Table-header consistency — the Standard Fees table now uses Token Bridge & Same-Chain Wrap/Unwrap (line 34), matching the revenue-share table (line 64). The wrap/unwrap mapping is now unambiguous.
  • Chain namingBNB Chain is now used consistently (lines 97 and 106). One follow-up worth noting: BNB Chain still isn't in the AGENTS.md §5 canonical chain-names list, so it'd be worth adding there in a separate change to keep the style guide authoritative.

Math reconciliation (✅ still holds) — the standard-fee × (1 − revenue-share) products reconcile with the old absolute-fee table:

Pair Standard Rev share ($10M–$100M) Net Old value
Stablecoin 0.01% 34% 0.0066% 0.0066% ✓
Major 0.06% 25% 0.045% 0.045% ✓
Minor 0.15% 33.33% 0.10% 0.10% ✓

The $100M–$1B tier (67% / 50% / 66.67%) reconciles the same way to the old 0.0033% / 0.03% / 0.05%. Internally consistent.


Remaining suggestions (all non-blocking)

1. "major stablecoin" is now undefined (clarity)
The Major token swaps definition (line 101) says swaps happen "between any major token and any major stablecoin" — but "major stablecoin" isn't defined anywhere on the page. The old text enumerated it inline (USDT, DAI, USDe and USDs). Since the Stablecoin category (line 98) now lists 15 stablecoins, a reader can't tell whether "major stablecoin" means all of them or a subset. Recommend either enumerating the major stablecoins or pointing to the stablecoin list explicitly.

Fix this →

2. "Note:" as plain prose instead of a callout (style, §2.5)
The Hyperliquid note (line 24) uses a bare Note: prefix. AGENTS.md §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this is a judgment call — but worth considering an <Info> for consistency.

3. Frontmatter description plural (nit)
description: "Learn about Relay's fee structures" (line 3) — "structures" plural reads slightly oddly against the singular title "Fee Structure". Consider "Learn how Relay's fees work" or "...fee structure".

4. Trailing whitespace (nit, outside diff)
Line 155 still has a trailing space. Outside this PR's diff scope, but easy to clean up while here.


Verdict: Content is accurate, math is sound, and the two highest-priority items from the prior review are fixed. Remaining items are clarity/style nits — item 1 (undefined "major stablecoin") is the most worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 13s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Post review feedback

Re-reviewing after the latest pushes. Two items from prior reviews are now resolved:

  • Chain naming — line 106 now reads AVAX on Avalanche to Aster on BNB Chain, matching line 97. "BNB Chain" is now used consistently (commit 42cf14e).
  • Frontmatter description — line 3 is now singular "Learn about Relay's fee structure" (commit 0cdaa3a).

This is a strong rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) and the explicit "regular users pay origin gas directly to the network" note remove a common misconception, and the category definitions with concrete examples are a genuine improvement.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Still open

1. major stablecoin is undefined (clarity)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but major stablecoin is never defined on the page — there is only the single 15-token "Stablecoin swaps" list (line 98). A reader can't tell whether "major stablecoin" means all 15 or a subset. Recommend dropping "major" so it reads "any major token and any stablecoin", or defining the subset explicitly.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) still uses a bare Note: prefix. §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. BNB Chain not in the §5 canonical chain-names list (terminology)
Now that the page standardizes on "BNB Chain", consider adding it to the canonical chain-names list in §5 of AGENTS.md so the convention is recorded for future edits. (Out of this file's scope, but worth a follow-up.)


Minor / non-blocking (all pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — e.g. "added on top of a Relay quote".
  • Line 155 still has trailing whitespace, despite the PR description noting trailing-whitespace cleanup.

None of these are blocking — the content is accurate and the math is sound. Item 1 (undefined "major stablecoin") is the only remaining in-scope clarity item worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 58s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing after the latest pushes. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note removes a common misconception, and the category definitions with concrete examples are a genuine improvement.

Previously-flagged items now resolved ✅

  • Table-header consistency — the Standard Fees table (line 34) and revenue-share table (line 64) both use Token Bridge & Same-Chain Wrap/Unwrap. The wrap/unwrap mapping is unambiguous.
  • Chain namingBNB Chain is now used consistently on lines 97 and 106.
  • Frontmatter description — now singular ("Learn about Relay's fee structure"), matching the title.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Still open (all non-blocking)

1. "major stablecoin" is undefined (clarity)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but major stablecoin is never defined on the page — there is only the single 15-token "Stablecoin swaps" list (line 98). A reader can't tell whether "major stablecoin" means all 15 or a subset. Recommend either dropping "major" so it reads "any major token and any stablecoin", or defining the subset explicitly. This is the only remaining in-scope clarity item worth addressing before merge.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix. §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. BNB Chain not in the §5 canonical chain-names list (terminology)
Now that the page standardizes on "BNB Chain", consider adding it to the canonical chain-names list in §5 of AGENTS.md so the convention is recorded for future edits. (Out of this file's scope — worth a separate follow-up.)


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay"). Suggest "added on top of a Relay quote".
  • Line 155: still has trailing whitespace (confirmed), despite the PR description noting trailing-whitespace cleanup. Outside the diff scope.

Verdict: Content is accurate, math is sound, and the two highest-priority items from earlier reviews (table headers, chain naming) are fixed. Remaining items are clarity/style nits — item 1 (undefined "major stablecoin") is the most worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 4s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Post review feedback

Re-reviewing after the latest push. This is a strong, well-structured rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note clears up a common misconception, and the category definitions with concrete examples are a genuine improvement.

Resolved since earlier reviews ✅

  • Frontmatter description — now singular "Learn about Relay's fee structure" (line 3).
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Table-header consistency — both tables use Token Bridge & Same-Chain Wrap/Unwrap (lines 34, 64).

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. docs.json references the page by path (line 88), so the Relay FeesFee Structure title change is picked up automatically — no nav update needed.


Still open

1. major stablecoin is undefined (clarity — only remaining in-scope item)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but major stablecoin is never defined on the page — there is only the single 15-token "Stablecoin swaps" list (line 98). A reader can't tell whether "major stablecoin" means all 15 or a subset (the old text enumerated it inline as USDT, DAI, USDe and USDs). Recommend either dropping "major" so it reads "any major token and any stablecoin", or defining the subset explicitly.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — e.g. "added on top of a Relay quote".
  • Line 155 still has trailing whitespace, despite the PR description noting trailing-whitespace cleanup.
  • BNB Chain isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded.

Verdict: Content is accurate and the math is sound. The two highest-priority items from prior reviews are fixed. Item 1 (undefined "major stablecoin") is the only remaining in-scope clarity item worth addressing before merge — everything else is style/nit.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 0s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing after the latest commits (most recently bee0dc5, renaming "Same token bridging" → "Token Bridging"). This continues to be a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note removes a common misconception, and the category definitions with concrete examples are a genuine improvement.

Previously-flagged items now resolved ✅

  • Table-header consistency — Standard Fees table (line 34) and revenue-share table (line 64) both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is now used consistently on lines 97 and 106.
  • Frontmatter description — now singular ("Learn about Relay's fee structure", line 3), matching the title.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Still open (all non-blocking)

1. "major stablecoin" is undefined (clarity)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but major stablecoin is never defined on the page — there's only the single 15-token "Stablecoin swaps" list (line 98). A reader can't tell whether "major stablecoin" means all 15 or a subset. Recommend either dropping "major" so it reads "any major token and any stablecoin", or defining the subset explicitly. This is the one remaining in-scope clarity item worth addressing before merge.

Fix this →

2. Token Bridging (definition) vs Token Bridge (tables) — new minor inconsistency (terminology)
The latest rename made the definition label **Token Bridging:** (line 91), but both fee tables still head the column Token Bridge & Same-Chain Wrap/Unwrap (lines 34, 64). The noun/gerund mismatch is a small snag for a reader mapping the definition to its fee. Consider aligning the two (e.g. **Token Bridge:** in the definition list) so the category name is identical everywhere.

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix. §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

4. BNB Chain not in the §5 canonical chain-names list (terminology)
Now that the page standardizes on "BNB Chain", consider adding it to the canonical chain-names list in §5 of AGENTS.md so the convention is recorded for future edits. (Out of this file's scope — worth a separate follow-up.)


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay"). Suggest "added on top of a Relay quote".
  • Line 155: still has trailing whitespace (confirmed), despite the PR description noting trailing-whitespace cleanup.

Verdict: Content is accurate, the math is sound, and all of the highest-priority items from earlier reviews (table headers, chain naming, frontmatter) are fixed. Remaining items are clarity/style nits — item 1 (undefined "major stablecoin") is the most worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 53s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing after the latest push. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the new transaction-type definitions with concrete examples are a genuine improvement.

Resolved since earlier reviews ✅

  • Table-header consistency — Standard Fees table (line 34) and revenue-share table (line 64) both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is now used consistently (lines 97 and 106).
  • Frontmatter description — now singular ("Learn about Relay's fee structure", line 3), matching the title.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Still open (all non-blocking)

1. "major stablecoin" is undefined (clarity — top in-scope item)
Line 101 says major swaps include pairings "between any major token and any major stablecoin", but major stablecoin is never defined on the page — there's only the single 15-token "Stablecoin swaps" list (line 98). A reader can't tell whether "major stablecoin" means all 15 or a subset (the old text enumerated it inline as USDT, DAI, USDe and USDs). Recommend either dropping "major" so it reads "any major token and any stablecoin", or defining the subset explicitly.

Fix this →

2. Token Bridging (definition) vs Token Bridge (tables) — terminology mismatch
The definition-list label on line 91 reads **Token Bridging:**, but both fee tables head the column Token Bridge & Same-Chain Wrap/Unwrap (lines 34, 64). The noun/gerund mismatch is a small snag for a reader mapping a definition to its fee. Consider aligning the two (e.g. **Token Bridge:** in the definition list) so the category name is identical everywhere.

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — e.g. "added on top of a Relay quote".
  • Line 155: still has a trailing space, despite the PR description noting trailing-whitespace cleanup.
  • BNB Chain isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded.

Verdict: Content is accurate, the math is sound, and all the highest-priority items from earlier reviews are fixed. The remaining items are clarity/style nits — item 1 (undefined "major stablecoin") and item 2 (Token Bridging/Token Bridge mismatch) are the two most worth addressing before merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 2s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing after the latest commit (bf4bd2a, adding the "Major Stablecoin" defined term). This remains a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note clears up a common misconception, and the category definitions with concrete examples are a genuine improvement.

Previously-flagged item now resolved ✅

  • major stablecoin was undefined — line 98 now introduces (each, a "Major Stablecoin"), anchoring the term to the explicit 15-token list. The prior highest-priority clarity item is addressed.

Still resolved from earlier reviews ✅

  • Table-header consistency — Standard Fees table (line 34) and revenue-share table (line 64) both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently on lines 97 and 106.
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Remaining suggestions (all non-blocking)

1. Capitalization of the new defined term (clarity nit)
Line 98 defines the term as "Major Stablecoin" (capitalized), but the one place it's actually used — line 101, "any major token and any major stablecoin" — uses lowercase. Since you went to the trouble of defining a proper term, capitalizing the usage (any major token and any Major Stablecoin) would make the reference unambiguous and match the defined-term convention.

Fix this →

2. Token Bridging (definition) vs Token Bridge (table headers) — terminology
The definition-list label on line 91 reads **Token Bridging:** (gerund), while both fee-table headers (lines 34, 64) say Token Bridge. The noun/gerund mismatch is a small snag for a reader mapping the definition back to its fee column. Consider aligning them (e.g. **Token Bridge:** in the definition list).

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — e.g. "added on top of a Relay quote".
  • Line 155: still has trailing whitespace, despite the PR description noting trailing-whitespace cleanup.
  • BNB Chain isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every highest-priority item from the earlier review rounds (table headers, chain naming, frontmatter, and the previously-undefined "major stablecoin") is now resolved. The remaining items are pure clarity/style nits — none block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 12s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples are a genuine improvement.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees table (line 34) and revenue-share table (line 64) both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — now singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined — line 98 now anchors the term with (each, a "Major Stablecoin") against the explicit 15-token list.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Remaining suggestions (all non-blocking)

1. Defined term "Major Stablecoin" is capitalized but its usage is lowercase (clarity nit)
Line 98 defines (each, a "Major Stablecoin"), but the one place it's used — line 101, "any major token and any major stablecoin" — is lowercase. Capitalizing the usage (any major token and any Major Stablecoin) makes the reference unambiguous and matches the defined-term convention.

Fix this →

2. Token Bridging (definition) vs Token Bridge (table headers) — terminology
The definition-list label on line 91 reads **Token Bridging:** (gerund), while both fee-table headers (lines 34, 64) say Token Bridge. Likewise line 93's **Same-chain wrap/unwrap:** vs the header's Same-Chain Wrap/Unwrap. Aligning the category names exactly (e.g. **Token Bridge:**) helps a reader map each definition to its fee column.

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.


Minor / non-blocking (pre-existing, outside the diff)

  • Line 110 (App Fees): "Fees added on top of a Relay by the integrator" reads awkwardly ("on top of a Relay") — e.g. "added on top of a Relay quote".
  • Line 155: still has trailing whitespace (confirmed), despite the PR description noting trailing-whitespace cleanup.
  • BNB Chain isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded.

Verdict: Content is accurate, the math is sound, and every higher-priority item from the earlier rounds (table headers, chain naming, frontmatter, undefined "major stablecoin") is resolved. The remaining items are pure clarity/style nits — none block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 54s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This remains a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"), and line 101 uses the capitalized defined terms (any Major Token and any Major Stablecoin).
  • App Fees wording — line 110 now reads "Fees added on top of a Relay quote." — the earlier "on top of a Relay" awkwardness is fixed.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent.


Still open

1. crosschain should be cross-chain (terminology, §5) — in-scope
Line 104 (Minor swaps) reads "same-chain or crosschain token swaps". Per §5 of AGENTS.md, cross-chain is hyphenated and lowercase — and every other category on this page already uses "same-chain or cross-chain" (lines 98, 101). Confirmed it's still the lone spelling outlier, and it's inside the diff.

Fix this →

2. Definition labels vs. table headers — terminology mismatch (clarity)
The **Relay Transaction Types:** list uses gerund/plural labels — **Token Bridging:** (91), **Same-chain wrap/unwrap:** (93), **Stablecoin swaps:** (98), **Major swaps:** (101), **Minor swaps:** (104) — while both fee tables head the columns with singular noun forms: Token Bridge & Same-Chain Wrap/Unwrap, Stablecoin Swap, Major Swap, Minor Swap (lines 34–37, 64–67). A reader mapping a definition back to its fee column hits a small noun/gerund + casing snag on each row. Aligning the names exactly (e.g. **Stablecoin Swap:**, **Major Swap:**, **Minor Swap:**) would make the mapping 1:1. Non-blocking.

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

4. Line 155 trailing whitespace (nit)
Confirmed still present — line 155 ends with a trailing space, despite the PR description noting trailing-whitespace cleanup. Outside the diff scope but trivial to clean up while here.

Fix this →


Minor / non-blocking

  • "Major Stablecoin" defined-term naming: line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category — every listed stablecoin is "major". The "Major" qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned.
  • BNB Chain isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds (table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording) is resolved. The remaining items are clarity/terminology nits — item 1 (crosschaincross-chain) is the one clear in-scope §5 fix worth making before merge. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 12s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth flagging (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). That reads as intentional — just calling it out so it isn't an accidental inversion of prior behavior.


Still open

1. crosschain should be cross-chain (terminology, §5) — in-scope
Line 104 (Minor swaps) reads "same-chain or crosschain token swaps". Per §5 of AGENTS.md, cross-chain is hyphenated and lowercase — and every other category on this page already uses "same-chain or cross-chain" (lines 98, 101). This is the lone spelling outlier and it's inside the diff — the one clear fix worth making before merge.

Fix this →

2. Definition labels vs. table headers — terminology mismatch (clarity, non-blocking)
The **Relay Transaction Types:** list uses gerund/plural labels — **Token Bridging:** (91), **Same-chain wrap/unwrap:** (93), **Stablecoin swaps:** (98), **Major swaps:** (101), **Minor swaps:** (104) — while both fee tables head the columns with singular noun forms: Token Bridge & Same-Chain Wrap/Unwrap, Stablecoin Swap, Major Swap, Minor Swap (lines 34–37, 64–67). A reader mapping a definition back to its fee column hits a small noun/gerund + casing snag on each row. Aligning the names exactly (e.g. **Stablecoin Swap:**, **Major Swap:**, **Minor Swap:**) would make the mapping 1:1.

Fix this →

3. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

4. Line 155 trailing whitespace (nit)
Confirmed still present — line 155 ends with a trailing space, despite the PR description noting trailing-whitespace cleanup. Outside the diff scope but trivial to clean up while here.

Fix this →


Minor / non-blocking

  • "Major Stablecoin" defined-term naming: line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category — every listed stablecoin is "major". The "Major" qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned.
  • BNB Chain is now used consistently on the page (lines 97, 106) but isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds (table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording) is resolved. The remaining items are clarity/terminology nits — item 1 (crosschaincross-chain) is the one clear in-scope §5 fix worth making before merge. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 16s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"), and line 101 uses the capitalized defined terms (any Major Token and any Major Stablecoin).
  • App Fees wording — line 110 now reads "Fees added on top of a Relay quote."
  • crosschaincross-chain — line 104 now reads "same-chain or cross-chain token swaps", matching the rest of the page and §5. ✅ (newly resolved)

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth flagging (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). That reads as intentional — just calling it out so it isn't an accidental inversion of prior behavior.


Still open (all non-blocking)

1. Definition labels vs. table headers — terminology mismatch (clarity)
The **Relay Transaction Types:** list uses gerund/plural labels — **Token Bridging:** (91), **Same-chain wrap/unwrap:** (93), **Stablecoin swaps:** (98), **Major swaps:** (101), **Minor swaps:** (104) — while both fee tables head the columns with singular noun forms: Token Bridge & Same-Chain Wrap/Unwrap, Stablecoin Swap, Major Swap, Minor Swap (lines 34–37, 64–67). A reader mapping a definition back to its fee column hits a small noun/gerund + casing snag on each row. Aligning the names exactly (e.g. **Token Bridge & Same-Chain Wrap/Unwrap:**, **Stablecoin Swap:**, **Major Swap:**, **Minor Swap:**) would make the mapping 1:1.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. Line 155 trailing whitespace (nit)
Confirmed still present (via grep) — line 155 ends with a trailing space, despite the PR description noting trailing-whitespace cleanup. Outside the diff scope but trivial to clean up while here.

Fix this →


Minor / non-blocking

  • "Major Stablecoin" defined-term naming: line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category — every listed stablecoin is "major". The "Major" qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned.
  • BNB Chain is used consistently on the page but isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds — table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording, and crosschaincross-chain — is now resolved. The remaining items are pure clarity/style nits. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 13s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"), and line 101 uses the capitalized defined terms (any Major Token and any Major Stablecoin).
  • App Fees wording — line 110 now reads "Fees added on top of a Relay quote."
  • crosschaincross-chain — confirmed resolved; line 104 now reads "same-chain or cross-chain token swaps". No crosschain occurrences remain on the page.

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth flagging (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). That reads as intentional — just calling it out so it isn't an accidental inversion of prior behavior.


Still open (all non-blocking)

1. Definition labels vs. table headers — terminology mismatch (clarity)
The **Relay Transaction Types:** list uses lowercase/gerund labels — **Token Bridging:** (91), **Same-chain wrap/unwrap:** (93), **Stablecoin swap:** (98), **Major swap:** (101), **Minor swap:** (104) — while both fee tables head the columns with Title-Case noun forms: Token Bridge & Same-Chain Wrap/Unwrap, Stablecoin Swap, Major Swap, Minor Swap (lines 34–37, 64–67). The subheadings were made singular in a recent commit, which closes most of the gap; the remaining snag is the Token Bridging (gerund) vs Token Bridge form and the casing on Same-chain wrap/unwrap. Aligning them exactly (e.g. **Token Bridge & Same-Chain Wrap/Unwrap:**) would make the definition→fee-column mapping 1:1.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. Line 155 trailing whitespace (nit)
Confirmed still present (via grep) — line 155 ends with a trailing space, despite the PR description noting trailing-whitespace cleanup. Outside the diff scope but trivial to clean up while here.

Fix this →


Minor / non-blocking

  • "Major Stablecoin" defined-term naming: line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category — every listed stablecoin is "major". The "Major" qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned.
  • BNB Chain is used consistently on the page but isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds — table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording, and crosschaincross-chain — is now resolved. The remaining items are pure clarity/style nits. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 24s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"), and line 101 uses the capitalized defined terms (any Major Token and any Major Stablecoin).
  • App Fees wording — line 110 now reads "Fees added on top of a Relay quote."
  • crosschaincross-chain — line 104 now reads "same-chain or cross-chain token swaps", matching the rest of the page and §5.
  • Line 155 trailing whitespace — confirmed removed (grep finds no trailing whitespace anywhere on the page now). ✅ newly resolved

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth flagging (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). That reads as intentional — just calling it out so it isn't an accidental inversion of prior behavior.


Still open (all non-blocking)

1. Definition labels vs. table headers — terminology mismatch (clarity)
The **Relay Transaction Types:** list uses gerund/lowercase labels — **Token Bridging:** (91), **Same-chain wrap/unwrap:** (93), **Stablecoin swap:** (98), **Major swap:** (101), **Minor swap:** (104) — while both fee tables head the columns with title-case noun forms: Token Bridge & Same-Chain Wrap/Unwrap, Stablecoin Swap, Major Swap, Minor Swap (lines 34–37, 64–67). The biggest snag is Token Bridging (gerund) vs Token Bridge (noun); the others differ only in casing. Aligning the names exactly (e.g. **Token Bridge & Same-Chain Wrap/Unwrap:**, **Stablecoin Swap:**, **Major Swap:**, **Minor Swap:**) would make the definition→fee-column mapping 1:1.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. "Major Stablecoin" defined-term naming (clarity nit)
Line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category anywhere — every listed stablecoin is "major". The "Major" qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned. (Note: "Major Token" on line 101 does have a contrasting non-major case via the Minor swap definition, so that one reads fine.)


Minor / non-blocking (outside the diff)

  • BNB Chain is now used consistently on the page but isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds — table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording, crosschaincross-chain, and the line-155 trailing whitespace — is now resolved. The remaining items are pure clarity/style nits. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 7s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and current head state
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Post review feedback

Re-reviewing the current head. This is a strong, well-organized rewrite. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved across the review rounds ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Chain namingBNB Chain is used consistently (lines 97 and 106).
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"); line 101 uses the capitalized defined terms.
  • App Fees wording — line 110 reads "Fees added on top of a Relay quote."
  • crosschaincross-chain — line 104 now reads "same-chain or cross-chain token swaps"; no crosschain occurrences remain.
  • Token BridgingToken Bridge — the definition label on line 91 now matches the table header's noun form.
  • Trailing whitespace — confirmed gone (grep finds none on the page).

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth flagging (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). That reads as intentional — just calling it out so it isn't an accidental inversion of prior behavior.


Still open (all non-blocking)

1. Residual casing mismatch: definition labels vs. table headers (clarity nit)
Token Bridge now matches, but the remaining definition labels still differ only in casing from the table headers: **Same-chain wrap/unwrap:** (93) vs Same-Chain Wrap/Unwrap, **Stablecoin swap:** (98) vs Stablecoin Swap, **Major swap:** (101) vs Major Swap, **Minor swap:** (104) vs Minor Swap. Title-casing the labels (e.g. **Stablecoin Swap:**) would make the definition→fee-column mapping 1:1. The biggest gap (the Token Bridging gerund) is already fixed, so this is purely cosmetic.

Fix this →

2. Note: as plain prose instead of a callout (style, §2.5 — judgment call)
The Hyperliquid note (line 24) uses a bare Note: prefix; §2.5 reserves <Note>/<Info> for this. It's nested inside a numbered list item where MDX callouts can render awkwardly, so this remains a judgment call — non-blocking.

3. "Major Stablecoin" defined-term naming (clarity nit)
Line 98 labels the full 15-token set "Major Stablecoin", but there's no contrasting "minor stablecoin" category — every listed stablecoin is "major". The qualifier may read as implying a tier that doesn't exist. Consider just "Stablecoin" as the defined term unless a minor-stablecoin distinction is planned. ("Major Token" on line 101 reads fine, since the Minor swap definition gives it a contrasting case.)


Minor / non-blocking (outside the diff)

  • BNB Chain is used consistently on the page but isn't yet in the §5 canonical chain-names list in AGENTS.md — worth a separate follow-up so the convention is recorded for future edits.

Verdict: Content is accurate, the math is sound, and every higher-priority item from earlier rounds — table headers, chain naming, frontmatter, undefined "major stablecoin", App Fees wording, crosschaincross-chain, the Token Bridging gerund, and trailing whitespace — is now resolved. The remaining items are pure clarity/style nits. None block merge.
claude/awesome-carson-2v7gwp

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude encountered an error after 4m 12s —— View job


I'll analyze this and get back to you.

@vezzabel

Copy link
Copy Markdown
Collaborator Author

Hi @pedromcunha I checked this PR against the internal GDoc draft and it looks good. I didn't make these changes that were flagged by code review:

  1. Chain naming: "BNB" or "BNB Chain" - defer to you what our standard is.
  2. The Hyperliquid note (line 24) - I didn't change how this is displayed, but defer to you if there's a clearer way to show it. We get a lot of questions about this.
  3. There's no such thing as "minor stablecoin" so this can be ignored.

@vezzabel vezzabel requested a review from pedromcunha June 12, 2026 01:15
pedromcunha
pedromcunha previously approved these changes Jun 12, 2026
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Claude finished @vezzabel's task in 1m 22s —— View job


Code Review: PR #337 — Expand and clarify fee structure documentation

  • Read the changed file and diff against origin/main
  • Check against the repo style guide (AGENTS.md)
  • Review for correctness, clarity, and consistency
  • Verify the standard-fee / revenue-share math reconciles
  • Account for the author's responses to prior feedback

Re-reviewing the current head. This is a strong, well-organized rewrite, and at this point nearly every item raised across the review rounds is resolved. The Execution Fees breakdown (flat fee / always-included destination gas / origin gas for gasless only) plus the explicit "regular users pay origin gas directly to the network" note (line 15) removes a common misconception, and the transaction-type definitions with concrete examples read clearly.

Resolved ✅

  • Table-header consistency — Standard Fees (line 34) and revenue-share (line 64) tables both use Token Bridge & Same-Chain Wrap/Unwrap.
  • Frontmatter description — singular "Learn about Relay's fee structure" (line 3), matching the title.
  • major stablecoin undefined / capitalization — line 98 anchors the term with (each, a "Major Stablecoin"); line 101 uses the capitalized defined terms.
  • App Fees wording — line 110 now reads "Fees added on top of a Relay quote."
  • crosschaincross-chain — line 104 reads "same-chain or cross-chain token swaps"; no crosschain occurrences remain.
  • Token BridgingToken Bridge — definition label (line 91) matches the table-header noun form.
  • Trailing whitespace — confirmed gone (line 155 and elsewhere).

Math verification (✅ passes): standard fee × (1 − revenue-share %) reconciles exactly to the prior per-tier absolute fees:

Pair Standard $10M–$100M Net $100M–$1B Net
Stablecoin 0.01% 34% 0.0066% ✓ 67% 0.0033% ✓
Major 0.06% 25% 0.045% ✓ 50% 0.03% ✓
Minor 0.15% 33.33% 0.10% ✓ 66.67% 0.05% ✓

Internally consistent. One semantic shift worth noting (not a bug): the old table reduced the fee charged to the end user at higher volume tiers, whereas the new model holds the end-user fee at the Standard rate and routes the difference to the integrator as a revenue share that "cannot be used to discount the Relay product to end users" (line 58). @vezzabel's note that this matches the internal GDoc draft confirms it's intentional. 👍


Author-deferred items (acknowledged, not re-flagging)

@vezzabel has reviewed against the internal draft and deferred the following to @pedromcunha — I'm noting them as closed from my side:

  1. Chain naming (BNB vs BNB Chain) — currently consistent as "BNB Chain" on lines 97 and 106. Deferred to @pedromcunha for the house standard; if confirmed, worth adding to the §5 canonical chain-names list in AGENTS.md (out of this file's scope).
  2. Hyperliquid Note: (line 24) — §2.5 would normally reserve <Note>/<Info> for this, but it's nested in a numbered list where MDX callouts render awkwardly. Left as-is by the author; deferred to @pedromcunha on whether a clearer presentation is wanted, especially given how often this comes up in support.
  3. "Major Stablecoin" naming — author confirms there is no "minor stablecoin" tier, so the defined term is fine as-is. Closing this.

One residual nit (non-blocking, optional)

Casing on the three swap definition labels. Lines 98/101/104 read **Stablecoin swap:**, **Major swap:**, **Minor swap:** (lowercase "swap"), while the fee-table headers use Title Case: Stablecoin Swap, Major Swap, Minor Swap (lines 35–37, 65–67). Token Bridge and Same-Chain Wrap/Unwrap already match; these three are the last to differ, by casing only. Title-casing the labels would make the definition→fee-column mapping 1:1. Purely cosmetic — fine to leave.

Fix this →


Verdict: Content is accurate, the math is sound, and the change matches the internal GDoc draft per the author. Every higher-priority item is resolved; the only remaining item is an optional cosmetic casing tweak. Nothing blocks merge.
claude/awesome-carson-2v7gwp

@pedromcunha pedromcunha merged commit 2d98610 into main Jun 12, 2026
4 checks passed
@pedromcunha pedromcunha deleted the claude/awesome-carson-2v7gwp branch June 12, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants