Add description to the Config tab - #1472
jaykim1213 wants to merge 1 commit into
Conversation
|
A preview of is uploaded and can be seen here: ✨ https://revisit.dev/study/PR1472 ✨ Changes may take a few minutes to propagate. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df74e8ad13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Text> | ||
| {hasError | ||
| ? 'Unable to load saved Study Config versions. Please try again.' | ||
| : 'No Study Configs have been saved yet.'} |
There was a problem hiding this comment.
When analysis opens with zero visible participants, StudyAnalysisTabs passes undefined while its independent current-config-hash lookup is pending or after it fails; ConfigView then successfully fetches an empty hash list, clears hasError, and displays this message even though a current saved config may exist or its lookup failed. Preserve the lookup status/error in the prop contract so the view remains loading or reports failure before concluding that no configs are saved.
AGENTS.md reference: AGENTS.md:L41-L42
Useful? React with 👍 / 👎.
1 participant
Why
The Config tab does not explain its purpose, and “No data available” does not distinguish missing saved configs from a loading failure.
Addresses #1251.
Architecture
This is a local UI change in ConfigView. A short description appears above the loading, table, and empty states. Config loading now tracks errors separately from successful empty results and clears the error after a successful fetch.
Config retrieval, current-config visibility, and view/download/compare actions retain their existing behavior.
User-facing impact
Validation
yarn unittest run src/analysis/individualStudy/config/tests/ConfigView.spec.tsx— 27 tests passed after the final copy changes.yarn typecheck— passed before the final copy changes.yarn lint— no errors; two existing warnings before the final copy changes.Risk and rollout
No special rollout or storage migration is needed. The change affects Config tab messaging and loading-state presentation; browser layout remains unverified.