Conversation
Contributor
|
A preview of cc1096c is uploaded and can be seen here: ✨ https://revisit.dev/study/PR1474 ✨ Changes may take a few minutes to propagate. |
9 tasks
JackWilb
force-pushed
the
codex/1473-replay-metadata
branch
from
September 17, 2026 15:07
7acbfa8 to
e16fee9
Compare
JackWilb
force-pushed
the
codex/1473-replay-metadata
branch
from
September 17, 2026 15:09
e16fee9 to
cc1096c
Compare
JackWilb
marked this pull request as ready for review
September 17, 2026 18:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Opening a participant replay currently runs the normal IP-enrichment path. When the viewer's IP differs from the participant's, that path replaces the participant's browser, screen, language, and IP metadata with the viewer's values.
Fixes #1473.
Architecture
This is a narrow startup guard rather than a storage redesign.
Shellalready identifies replay and analysis by the presence of the standardparticipantIdquery parameter. The metadata-enrichment block now skips IP collection and persistence in that mode while preserving the existing path for normal participant sessions.The regression test exercises both sides of that boundary: normal startup still requests the IP, while replay reaches the subsequent completion-status check without requesting the viewer's IP or calling
updateParticipantMetadata.User-facing impact
Viewing or replaying a participant session no longer replaces that participant's metadata with the viewer's environment. Normal study participation is unchanged.
Validation
corepack yarn unittest src/components/tests/Shell.spec.tsx --run— 17 tests passedcorepack yarn unittest --run— 164 files passed; 2,577 tests passed and 1 skippedcorepack yarn typecheck— passedcorepack yarn lint— passed with 2 pre-existing warnings outside this diffcorepack yarn build— passed with existing non-blocking bundle warningscc1096c2— running at the time of this updateRisk and rollout
No migration or configuration change is required. The main risk is accidentally suppressing metadata enrichment for normal participants; the existing-path assertion covers that boundary. Previously overwritten metadata is not restored by this change.