fix: close database handles after failed open#330
Open
marcus-pousette wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! That's a good catch. Please fill out the contribution checklist that I prepended to your top-level PR message before I merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
non-exclusive, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, sublicense, and distribute this
Contribution and such derivative works.
Contribution contains no content requiring a license from any third party.
Problem
SQLite can return a database handle even when
sqlite3_open_v2fails, and requires callers to close it. The wrapper currently tracks that failed handle, registers extension functions, and then throws before the caller can receive and release it.See the
sqlite3_open_v2contract.Change
sqlite3_errmsgbefore cleanup.The focused regression test forces
SQLITE_CANTOPENwith a non-null handle and proves that the original error is reported, the handle is closed and untracked, and extension registration is skipped.