Optimize laptop-mode-tools to support internationalization#170
Open
mrdengbo wants to merge 3 commits intorickysarraf:lmt-upstreamfrom
Open
Optimize laptop-mode-tools to support internationalization#170mrdengbo wants to merge 3 commits intorickysarraf:lmt-upstreamfrom
mrdengbo wants to merge 3 commits intorickysarraf:lmt-upstreamfrom
Conversation
Support laptop-mode-tools gui title display internationalization Fix the problem that the root privileges prompt does not display the corresponding user when the system is in the Chinese environment Added instructions for developers of internationalized languages
Contributor
Author
|
In this submission, I added a description of the language internationalization of laptop mode tools and optimized some minor issues |
rickysarraf
reviewed
Sep 6, 2021
| <name>MainWidget</name> | ||
| <message> | ||
| <location filename="../gui/lmt.py" line="55"/> | ||
| <location filename="../../../../gui/lmt.py" line="53"/> |
Owner
There was a problem hiding this comment.
Is this path correct ?
I assume the CWDIR would be usr/share/laptop-mode-tools/locale/ and in your proposed patch, if you traverse ../../../../ you are essentially chdir()ing to /
Can you please enlighten on this ?
Support laptop-mode-tools gui title display internationalization Fix the problem that the root privileges prompt does not display the corresponding user when the system is in the Chinese environment Added instructions for developers of internationalized languages
Contributor
Author
|
I added a script under the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support laptop-mode-tools gui title display internationalization
Fix the problem that the root privileges prompt does not display the corresponding user when the system is in the Chinese environment
Added instructions for developers of internationalized languages