Fix the bug of incorrect use of DEVICE variable in ethernet#172
Open
wxphaha wants to merge 1 commit intorickysarraf:lmt-upstreamfrom
Open
Fix the bug of incorrect use of DEVICE variable in ethernet#172wxphaha wants to merge 1 commit intorickysarraf:lmt-upstreamfrom
wxphaha wants to merge 1 commit intorickysarraf:lmt-upstreamfrom
Conversation
Part of the code uses DEVICE before assigning a value to DEVICE, which will cause the condition to be judged incorrectly. For example, if there is another network card NO-CARRIER, it will cause eth0 to be erroneously disabled. Move this part of the code after assigning a value to the DEVICE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the code uses DEVICE before assigning a value to DEVICE, which will cause the condition to be judged incorrectly.
For example, if there is another network card NO-CARRIER, it will cause eth0 to be erroneously disabled.
Move this part of the code after assigning a value to the DEVICE.
Author: xinpeng.wang wangxinpeng@uniontech.com