fix(bridge): record proposer on bridge proposals for relayer attribution - #505
Open
Anuoluwapo25 wants to merge 1 commit into
Open
fix(bridge): record proposer on bridge proposals for relayer attribution#505Anuoluwapo25 wants to merge 1 commit into
Anuoluwapo25 wants to merge 1 commit into
Conversation
Bridge proposals had no way to attribute a proposal to the relayer that submitted it, blocking per-relayer accountability and analytics for the indexer. create_proposal now takes and authenticates a proposer address, stores it on the BridgeProposal, and emits it in ProposalCreatedEvent. Closes rinafcode#495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proposer: Addressfield toBridgeProposal, captured and authenticated (require_auth()) at creation time inBFTConsensus::create_proposalProposalCreatedEventso off-chain indexers can attribute proposals without an extra storage readcreate_bridge_proposalcontract entrypoint and all existing tests for the new signatureCloses #495
Test plan
cargo test(full suite, including newcreate_proposal_records_and_emits_proposertest)cargo clippy --all-targets— no new warningscargo fmt --check— clean