Skip to content

perf(search): paginate SearchResults to cap mounted cards per page #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 4 commits into from
Aug 2, 2026
Merged

perf(search): paginate SearchResults to cap mounted cards per page #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78f7125
perf(search): paginate SearchResults to cap mounted cards per page
AvatarMiiDe Jul 30, 2026
7e57783
fix(types): resolve TS errors blocking CI type-check job
AvatarMiiDe Aug 2, 2026
05d2d4f
Merge branch 'main' into virtualization-searchresults
AvatarMiiDe Aug 2, 2026
9d87de2
fix(search): add missing imports to SearchResults to resolve TS errors
AvatarMiiDe Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions public/sitemap.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,85 +3,85 @@

<url>
<loc>https://teachlink.app</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>daily</changefreq>
<priority>1.0</priority>
</url>
<url>
<loc>https://teachlink.app/search</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/study-groups</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.7</priority>
</url>
<url>
<loc>https://teachlink.app/leaderboard</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.6</priority>
</url>
<url>
<loc>https://teachlink.app/certificates</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.5</priority>
</url>
<url>
<loc>https://teachlink.app/support</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>monthly</changefreq>
<priority>0.4</priority>
</url>
<url>
<loc>https://teachlink.app/privacy</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>monthly</changefreq>
<priority>0.3</priority>
</url>
<url>
<loc>https://teachlink.app/release-notes</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>monthly</changefreq>
<priority>0.3</priority>
</url>
<url>
<loc>https://teachlink.app/courses/1</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/courses/2</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/courses/3</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/courses/4</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/courses/5</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
<url>
<loc>https://teachlink.app/courses/6</loc>
<lastmod>2026-07-10</lastmod>
<lastmod>2026-08-02</lastmod>
<changefreq>weekly</changefreq>
<priority>0.8</priority>
</url>
Expand Down
99 changes: 92 additions & 7 deletions src/app/components/search/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use client';

import React from 'react';
import { Star, Clock, User, ArrowRight, SearchX } from 'lucide-react';
import React, { useState, useEffect, useCallback } from 'react';
import { Star, Clock, User, ArrowRight, SearchX, ChevronLeft, ChevronRight } from 'lucide-react';
import Image from 'next/image';
import Link from 'next/link';
import clsx from 'clsx';
Expand All @@ -27,14 +27,39 @@ interface SearchResultsProps {
isLoading?: boolean;
sortBy?: string;
onSortChange?: (sort: string) => void;
/** Number of cards per page. Defaults to 12. */
pageSize?: number;
/** Initial page number. Defaults to 1. */
initialPage?: number;
}

export const SearchResults: React.FC<SearchResultsProps> = ({
results,
isLoading = false,
sortBy = 'relevance',
onSortChange,
pageSize = 12,
initialPage = 1,
}) => {
const [currentPage, setCurrentPage] = useState(initialPage);

// Reset to page 1 whenever the result set changes (new search / filter)
useEffect(() => {
setCurrentPage(1);
}, [results]);

const totalPages = Math.max(1, Math.ceil(results.length / pageSize));
const safeCurrentPage = Math.min(currentPage, totalPages);
const startIndex = (safeCurrentPage - 1) * pageSize;
const endIndex = Math.min(startIndex + pageSize, results.length);
const visibleResults = results.slice(startIndex, endIndex);

const goToPrev = useCallback(() => setCurrentPage((p) => Math.max(1, p - 1)), []);
const goToNext = useCallback(
() => setCurrentPage((p) => Math.min(totalPages, p + 1)),
[totalPages],
);

if (isLoading) {
return (
<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4">
Expand Down Expand Up @@ -92,9 +117,17 @@ export const SearchResults: React.FC<SearchResultsProps> = ({

return (
<div>
{/* Sort Controls */}
{/* Sort Controls / Result Count */}
<div className="mb-6 flex justify-between items-center">
<p className="text-sm text-gray-600 dark:text-gray-400">{results.length} results found</p>
<p className="text-sm text-gray-600 dark:text-gray-400">
Showing{' '}
<span className="font-medium text-gray-900 dark:text-gray-100">
{results.length === 0 ? 0 : startIndex + 1}–{endIndex}
</span>{' '}
of{' '}
<span className="font-medium text-gray-900 dark:text-gray-100">{results.length}</span>{' '}
results
</p>
{onSortChange && (
<select
value={sortBy}
Expand All @@ -110,9 +143,12 @@ export const SearchResults: React.FC<SearchResultsProps> = ({
)}
</div>

{/* Results Grid */}
<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-6">
{results.map((course) => (
{/* Results Grid — only the current page's slice */}
<div
className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-6"
aria-label={`Search results page ${safeCurrentPage} of ${totalPages}`}
>
{visibleResults.map((course) => (
<Link
key={course.id}
href={`/courses/${course.id}`}
Expand Down Expand Up @@ -191,6 +227,55 @@ export const SearchResults: React.FC<SearchResultsProps> = ({
</Link>
))}
</div>

{/* Pagination Bar */}
{totalPages > 1 && (
<nav
className="mt-8 flex items-center justify-center gap-3"
aria-label="Search results pagination"
>
<button
id="search-results-prev-page"
type="button"
onClick={goToPrev}
disabled={safeCurrentPage === 1}
className={clsx(
'flex items-center gap-1 px-4 py-2 rounded-lg text-sm font-medium border transition-all duration-200',
safeCurrentPage === 1
? 'border-gray-200 dark:border-gray-700 text-gray-400 dark:text-gray-600 cursor-not-allowed bg-transparent'
: 'border-gray-300 dark:border-gray-600 text-gray-700 dark:text-gray-300 bg-white dark:bg-gray-800 hover:bg-gray-50 dark:hover:bg-gray-700 hover:border-gray-400 dark:hover:border-gray-500',
)}
aria-label="Previous page"
>
<ChevronLeft size={16} />
Previous
</button>

<span className="text-sm text-gray-600 dark:text-gray-400 select-none px-2">
Page{' '}
<span className="font-semibold text-gray-900 dark:text-gray-100">{safeCurrentPage}</span>{' '}
of{' '}
<span className="font-semibold text-gray-900 dark:text-gray-100">{totalPages}</span>
</span>

<button
id="search-results-next-page"
type="button"
onClick={goToNext}
disabled={safeCurrentPage === totalPages}
className={clsx(
'flex items-center gap-1 px-4 py-2 rounded-lg text-sm font-medium border transition-all duration-200',
safeCurrentPage === totalPages
? 'border-gray-200 dark:border-gray-700 text-gray-400 dark:text-gray-600 cursor-not-allowed bg-transparent'
: 'border-gray-300 dark:border-gray-600 text-gray-700 dark:text-gray-300 bg-white dark:bg-gray-800 hover:bg-gray-50 dark:hover:bg-gray-700 hover:border-gray-400 dark:hover:border-gray-500',
)}
aria-label="Next page"
>
Next
<ChevronRight size={16} />
</button>
</nav>
)}
</div>
);
};
Loading
Loading