Standardize client data fetching with a shared, cancelable useApiResource hook - #1148
Open
mrmoney10010-design wants to merge 3 commits into
Open
Standardize client data fetching with a shared, cancelable useApiResource hook#1148mrmoney10010-design wants to merge 3 commits into
mrmoney10010-design wants to merge 3 commits into
Conversation
Contributor
|
Well done on the job done so far1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel components all fetch through apiClient but each unwraps the response differently and handles the lifecycle inconsistently. src/components/ai/SmartNotifications.tsx reads res.data, src/components/ai/PersonalizedRecommendations.tsx reads r.items, src/components/ai/NaturalLanguageQuery.tsx reads r.results, and src/components/ai/LearningAssistant.tsx reads r.reply, while src/components/ai/IntelligentProgress.tsx and src/components/social/FollowingSystem.tsx read the payload directly. Only SmartNotifications guards against setState-after-unmount; the others can update unmounted components, and none pass an AbortSignal even though src/lib/api.ts (RequestConfig extends RequestInit) and src/hooks/useAbortController.ts already support cancellation. src/types/api.ts defines ApiResponse but it is applied inconsistently, so each panel reinvents its own loading/error state.
closes #1137