lancedb: Add versions 0.38.0, 0.39.0 - #1987
Merged
Merged
Conversation
Contributor
Author
|
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
Bot
force-pushed
the
github-actions/nightly-upgrade/lancedb
branch
from
September 18, 2026 07:30
f8b6e98 to
84cf4c3
Compare
github-actions
Bot
changed the title
CI failed applying patches/lancedb/<version>/0001*.patch for the two new pending versions: no patch directory existed for them yet (only 0.37.1 had one), so the glob matched nothing and `git apply` errored on a literal, missing filename. lancedb pins lance-core/lance-linalg to a different exact version per release (10.0.0 for v0.37.1, 11.0.0 for v0.38.0, 12.0.0 for v0.39.0), but the workflow hardcoded checking out lance v10.0.0 for the riscv64 SIMD fallback regardless of which lancedb version was being built. Make that checkout track whatever lance-core version the checked-out lancedb's own Cargo.toml pins, and add the corresponding per-version patch directories: - 0001 (Cargo.toml `[patch.crates-io]` redirect) is unchanged across lance versions, copied verbatim from 0.37.1. - 0002 (portable riscv64 SIMD fallback for lance-linalg's f32x8/f32x16/ i32x8/f64x4/f64x8) reuses patches/pylance/11.0.0's fallback patch, which applies cleanly to both lance v11.0.0 (0.38.0) and v12.0.0 (0.39.0) unchanged (verified locally with `git apply --check` against real lancedb/lance checkouts at both tags).
luhenry
force-pushed
the
github-actions/nightly-upgrade/lancedb
branch
from
September 19, 2026 18:29
165aafd to
0058999
Compare
lancedb's own test suite added test_blob.py in 0.38.0, which imports the lance package (published as pylance) at module scope for blob-v2 interop tests. It wasn't caught by the existing lance/polars module-scope exclusion list because that list predates 0.38.0 and pypi.riseproject.dev now hosts a pylance riscv64 wheel (11.0.0, see docs/packages/pylance.yaml), so pylance is added to CIBW_TEST_REQUIRES (pinned to that exact version per gotcha 30, since PyPI's newer pylance releases have no riscv64 wheel) instead of excluding the file. lance's blob.py API is unchanged between pylance 9.0.0 (what lancedb 0.38.0/0.39.0 themselves test against) and 11.0.0. Confirmed against CI run 35461355989 (jobs 105946021790/...), where both versions failed at collection with ModuleNotFoundError: No module named 'lance'.
…atible Both files were added in 0.38.0/0.39.0 and read golden fixtures (docs/src/python/python.md, rust/lancedb/tests/fixtures/first_class_functions/v1/*.json) that live outside the CIBW_TEST_SOURCES tree (only pyproject.toml and python/tests are copied into the isolated cibuildwheel test dir), so every test in both files fails with FileNotFoundError regardless of platform -- 23/23 failures on both 0.38.0 and 0.39.0. Same class of trap as the existing test_pyo3_abi_matches_minimum_supported_python deselect: a source-tree/golden-contract check, not installed-wheel runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.lancedb v0.37.1 -> v0.38.0, v0.39.0
Every
- version:entry added todocs/packages/lancedb.yamlis built by this PR's ownbuild-lancedb.ymlrun; merging publishes the wheels.