Skip to content

ci: open the nightly PRs as the riseproject-dev github app - #2083

Merged
luhenry merged 2 commits into
mainfrom
claude/version-upgrade-workflow-nqf4y0
Sep 18, 2026
Merged

luhenry merged 2 commits into
mainfrom
claude/version-upgrade-workflow-nqf4y0

Conversation

@luhenry

@luhenry luhenry commented Sep 18, 2026

Copy link
Copy Markdown
Member

Branches pushed and pull requests opened with the default GITHUB_TOKEN raise no events, so neither the per-package nightly upgrade PRs nor the documentation PR got any checks. nightly.yml and _publish-wheel.yml now mint an installation token for the riseproject-dev App, push and open their PRs with it, and commit as riseproject-dev[bot].

Setup needed before this takes effect (Settings → Secrets and variables → Actions):

Kind Name Value
Variable RISEPROJECT_APP_CLIENT_ID the App's Client ID (Iv23…), from the App's settings page
Secret RISEPROJECT_APP_PRIVATE_KEY the whole generated .pem, -----BEGIN… and -----END… lines included

create-github-app-token v3 deprecates app-id in favour of client-id, hence the Client ID rather than the numeric App ID.

The App also has to be installed on this repository, with Contents: read & write, Pull requests: read & write and Issues: read (check_versions.py looks up the Upstream milestone). With the variable unset, both workflows behave exactly as today: GITHUB_TOKEN, github-actions[bot], no checks.

What changed:

  • nightly.yml mints the token for the checkout, both gh steps and the branch pushes. Skipped on pull_request, where a fork or Dependabot has no access to the key and the job only needs to detect versions.
  • _publish-wheel.yml does the same for the docs PR, gated on main since nothing is published elsewhere. A reusable workflow sees no secret it is not handed, so all 707 build-<pkg>.yml callers pass app-private-key through — that is the bulk of the diff.
  • update_doc.py pushes the docs branch over GH_TOKEN rather than relying on whatever credentials the checkout persisted.
  • New ci_scripts/git-identity.sh resolves the commit identity for both, reading the bot account's numeric id from the API (that id is what ties a commit to the account).

One-off cost of merging: touching every build-<pkg>.yml matches their own pull_request path filters, so this PR triggers all 707 build workflows. 674 stop at setup with nothing to build; 33 packages have pending versions on main and will run a real (dry-run) build.

@luhenry
luhenry requested review from justeph and threexc September 18, 2026 11:07
@luhenry
luhenry force-pushed the claude/version-upgrade-workflow-nqf4y0 branch from 6ef343c to ef28f64 Compare September 18, 2026 11:08
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://riseproject-dev.github.io/python-wheels/pr-preview/pr-2083/

Built to branch gh-pages at 2026-09-18 14:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@luhenry
luhenry force-pushed the claude/version-upgrade-workflow-nqf4y0 branch 2 times, most recently from 80fc591 to a357544 Compare September 18, 2026 12:34
Branches pushed and PRs opened with GITHUB_TOKEN raise no events, so the
per-package upgrade PRs ended up with no checks at all. Mint a riseproject-dev
installation token when RISEPROJECT_APP_ID is set and commit as its bot,
falling back to GITHUB_TOKEN otherwise.
The documentation PR is opened from _publish-wheel.yml, so it needs the App
token too, or it keeps landing without checks. A reusable workflow gets no
secret it is not handed, hence the one line in each build workflow.
@luhenry
luhenry force-pushed the claude/version-upgrade-workflow-nqf4y0 branch from a357544 to 1059b2f Compare September 18, 2026 12:37
@luhenry luhenry changed the title ci: open the nightly PRs as the riseproject-dev App ci: open the nightly PRs as the riseproject-dev github app Sep 18, 2026
@luhenry
luhenry merged commit 562e512 into main Sep 18, 2026
1512 of 1518 checks passed
@luhenry
luhenry deleted the claude/version-upgrade-workflow-nqf4y0 branch September 18, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant