Conversation
luhenry
added a commit
that referenced
this pull request
Sep 21, 2026
Contributor
|
Builds the pybind11 typegraph extension from the upstream checkout with cibuildwheel, mirroring the manylinux_wheels job of upstream's build.yml. Tests run the wheel's own unit tests with the pytype.tests helpers staged alongside, since upstream excludes them from the distribution.
luhenry
marked this pull request as ready for review
September 21, 2026 13:09
luhenry
added a commit
that referenced
this pull request
Sep 21, 2026
CI green on PR #2168: the cp312 riscv64 wheel builds from the upstream checkout with cibuildwheel and the wheel's own unit suite passes (1746 passed, 22 skipped), with the publish job dry-running cleanly. Three reusable findings from the port: 512 - pytest's --ignore/--ignore-glob are silently inert under --pyargs <pkg>; --deselect works and its nodeids are relative to the package directory, not the rootdir pytest prints. 513 - a wheel can carry the test modules but not the helper package they import; stage the helpers with test-sources and copy them into the installed package from test-command. 514 - a tool that models a target Python version caps the matrix by itself, invisibly to a build-and-import check.
luhenry
added a commit
that referenced
this pull request
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytype2024.10.11Compiles pytype's typegraph solver, a pybind11 C++ extension. Upstream publishes no riscv64 wheel.
Mirrors upstream's
build.yml.Differs from upstream
build_scripts/wheels/manylinux.sh- the samepip wheelplusauditwheel repair.Matrix: cp312 only - pytype refuses to run on an interpreter past 3.12, which is why upstream ships cp310-cp312.
Testing
pytest --pyargs pytype, plus a one-file run of thepytypecommand.pytype.testshelpers a third of those tests import are excluded from the wheel, so they are staged beside it.main_test.py,test_error_docand two typeshed tests, which read files that only exist in a git checkout;test_die, which needs amkdirto fail and the container is root; and twoserialize_asttests, which fail identically on an x86 checkout of the same tag.License: Wheel bundles typeshed stubs and a CPython-derived
umarshal.py(Apache-2.0 and PSF-2.0), exactly as upstream's own wheels do.Built on cp312; 1746 passed, 22 skipped.