clickhouse-connect: Add version 1.9.0 - #2227
Merged
Merged
Conversation
Signed-off-by: riseproject-dev[bot] <330740410+riseproject-dev[bot]@users.noreply.github.com>
Contributor
|
1.9.0 added an async SQLAlchemy dialect (cc_sqlalchemy/asyncio.py) gated on greenlet. SQLAlchemy's own `greenlet>=1; platform_machine == ...` marker only lists aarch64/ppc64le/x86_64/amd64/win32, so pip never installs greenlet on riscv64, and pypi.riseproject.dev carries no riscv64 greenlet wheel either - the dialect module raises ImportError as designed. Running the suite (not grepping) found one file that fails to collect and two more tests, in otherwise-passing files, that import the dialect lazily inside the test body: - test_async_dialect.py: ImportError at collection - ignore the whole file. - test_async_alembic.py::test_async_alembic_offline_context_compiles_without_client and test_async_dialect_version.py::test_async_dialect_sqlalchemy_version_guard: both reference the dialect module at call time - deselect just those.
Stage `examples` alongside `tests` so test_checked_in_async_alembic_environment_carries_clickhouse_hooks can find examples/alembic_async/env.py, and add pytest-mock (an upstream test requirement already used by test_dns_connection_deadline's `mocker` fixture) to CIBW_TEST_REQUIRES.
luhenry
marked this pull request as ready for review
September 24, 2026 12:44
luhenry
deleted the
github-actions/nightly-upgrade/clickhouse-connect
branch
September 24, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.clickhouse-connect v1.8.0 -> v1.9.0
Every
- version:entry added todocs/packages/clickhouse-connect.yamlis built by this PR's ownbuild-clickhouse-connect.ymlrun; merging publishes the wheels.