Skip to content

onnxoptimizer: Add version 0.4.2 - #2258

Merged
luhenry merged 1 commit into
mainfrom
onnxoptimizer
Sep 24, 2026
Merged

luhenry merged 1 commit into
mainfrom
onnxoptimizer

Conversation

@luhenry

@luhenry luhenry commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Compiles onnxoptimizer's nanobind/CMake ONNX graph-optimizer extension, which statically links vendored onnx and protobuf. Upstream publishes no riscv64 wheel.

Mirrors upstream's build-and-test.yml.

Differs from upstream

  • Drops the flake8p/mypy lint step and the onnxscript/torch/torchvision test installs - none have riscv64 wheels and onnxscript isn't imported by any test

Matrix: cp311, cp312 only (upstream itself ships cp310/cp311/cp312-abi3, no cp313/cp314/cp314t). cp310 is dropped: onnx has no riscv64 wheel for it anywhere, and no py3-none-any fallback either.

Testing

  • onnxruntime added to test-requires on cp312 only, where our registry ships it, to run the onnxruntime-gated tests instead of skipping them

License: Statically links vendored onnx (Apache-2.0) and protobuf (BSD-3-Clause), which pulls in abseil-cpp (Apache-2.0); abseil ships no NOTICE file to propagate.

Build cp311/cp312 wheels for onnxoptimizer 0.4.2, following upstream's
own cibuildwheel matrix minus cp310 (onnx has no riscv64 wheel or
py3-none-any fallback for it). onnxruntime is added to the test
requirements on cp312, where our registry ships it, to exercise the
onnxruntime-gated tests instead of skipping them.
luhenry added a commit that referenced this pull request Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-24 06:43 UTC

luhenry commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

Heads up: the completed run only produced a cp312-manylinux_riscv64 build job (https://github.com/riseproject-dev/python-wheels/actions/runs/35941588765/job/107450461687) - no cp311 job ran, even though include lists both. An include list whose entries share no key with the base matrix (here just version) collapses onto a single combination instead of adding one job per entry; only the last entry's keys stick. Making python a real matrix dimension (python: [cp311, cp312] alongside include for onnxruntime) fixes it - see #2266 for the corrected shape.


Generated by Claude Code

@luhenry
luhenry merged commit bb62943 into main Sep 24, 2026
11 of 12 checks passed
@luhenry
luhenry deleted the onnxoptimizer branch September 24, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant