Conversation
PR #2198's first CI run only produced a cp314t job (the include-only tag/build keys collapsed the matrix onto one combination - gotcha 402), and that job's smoke test probed the maturin package shim's __file__ instead of the compiled submodule (gotcha 308's shape, without a name collision). Both fixed on the branch; run 35941432233 is green on cp38-abi3 and cp314t plus the publish dry run. Add gotcha 558: gotcha 308's sys.modules probe is the correct fix for *any* pure-Rust maturin project's __file__, not only once a name collision raises AttributeError - the wrap into a generated package is unconditional and interpreter-agnostic. Also record the queue-status update for ruff-format.
luhenry
added a commit
that referenced
this pull request
Sep 24, 2026
…__file__ shim) Replicates PR #2264's bookkeeping directly to main (renumbered 558->559 to avoid colliding with ifcopenshell's concurrently-landed 558) since that PR's own agent hit a permission wall pushing to main directly.
Member
Author
|
Superseded — this bookkeeping (queue status + the new gotcha, renumbered 558→559 to avoid a collision with ifcopenshell's concurrently-landed 558) landed directly on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookkeeping follow-up for #2198, which is now green on both matrix legs.
What happened on #2198: the first CI run only produced a
cp314tjob — theinclude:-onlytag/buildkeys collapsed the matrix onto one combination (gotcha 402's shape), so thecp38-abi3leg never ran at all. The one job that did run failed its smoke test because it probedruff_format.__file__on the maturin-generated package shim instead of the compiled submodule (gotcha 308's shape, without a name collision this time). Both fixed on theruff-formatbranch; run 35941432233 is green oncp38-abi3,cp314t, and the publish dry run.This PR:
.queue.yml:ruff-formatstatusci-running→ci-green, notes updated with the root causes and fixes.skills/python-project-porting/references/gotchas/compiled-vs-pure-detection.md(+ index): new gotcha 558 — gotcha 308'ssys.modulesprobe is the right fix for any pure-Rust maturin project's__file__, unconditionally, not only once a name collision raisesAttributeError. Also notes not to blame the interpreter for a per-leg failure until the sibling leg has actually run (it hadn't — gotcha 402's collapse, not a free-threading-specific quirk).No functional changes; this only updates queue tracking and the porting-skill reference docs.
Generated by Claude Code