vegafusion: Add version 2.0.3 - #2275
Merged
Merged
Conversation
PyO3/maturin bindings around vegafusion-core/runtime (arrow 55, a datafusion 48 fork, tonic). Mirrors build-datafusion.yml/build-pylance.yml: protobuf-src vendors protoc, and the abi3 wheel is built on cp312 (our registry's floor for pyarrow/duckdb, both hard test/runtime deps) and re-tested on cp313/cp314.
Contributor
|
pypa/cibuildwheel's action has no build: input (only package-dir, output-dir, config-file, only, extras); passing one is silently dropped with a warning buried at the end of the job log, after the whole ~5h build already ran. cibuildwheel then fell back to its default matrix floor (cp39) instead of the intended cp312/cp313/cp314 abi3 build list, so the test-install used a cp39 venv where arro3-core (a hard dependency, floor cp311) has no wheel - surfacing as an unrelated-looking "Could not find a version that satisfies the requirement arro3-core" failure in job 107513443514. Move the interpreter list to CIBW_BUILD under env:, the same knob build-datafusion.yml's own abi3 leg already uses for an identical setup. See gotcha 564.
Three independent causes behind the 125 test failures: - test_transformed_data.py (120 cases) calls altair's chart.transformed_data(), which compiles Vega-Lite through vl-convert-python. That package has no riscv64 wheel and cannot get one (its pinned rusty_v8 has no riscv64 build), so ignore the file and drop altair/vega-datasets, which nothing else collected imports. - test_get_column_usage.py and test_pretransform_specs.py read specs from ../../vegafusion-runtime/tests/specs, which was not copied into the test cwd; this also left test_pretransform_specs::test_it with an empty parameter set. Add the specs directory to CIBW_TEST_SOURCES. - test_transformer.py asserts pa.string() for converted string columns; pandas 3's default str dtype maps to arrow large_string. Upstream tests against pandas 2 (pixi.lock resolves 2.2.3, main pins >=2.2,<3), so pin pandas>=2.2,<3 the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vegafusion2.0.3PyO3/maturin bindings around the VegaFusion Rust runtime (Arrow + a DataFusion fork) that evaluates Vega/Vega-Lite chart transforms server-side. Upstream publishes no riscv64 wheel.
Mirrors upstream's
build_test.ymllinux-64 build/test jobs.Differs from upstream
--profile releaseinstead ofrelease-opt- keeps a cargo profile name every maturin sdist build in the container resolves, tuned viaCARGO_PROFILE_RELEASE_*instead>=2.2,<3in test deps - matches upstream's own pin, pandas 3's default string dtype breaks two unrelated arrow-dtype assertionsMatrix: built on cp312 (registry floor for pyarrow/duckdb, both test deps); retested on cp313/cp314.
Testing
License: OK