Conversation
Ports the Aerospike Python client (a cibuildwheel build-from-checkout of aerospike-client-python, which bundles the aerospike-client-c C client SDK as a git submodule). One patch is needed: as_arch.h's as_arch_pause() spin hint is only defined for __x86_64__/__aarch64__, and is used unconditionally from always-compiled spinlock/rwlock inline functions in as_atomic_gcc.h, so riscv64 hits an implicit-declaration -Werror failure without a portable no-op fallback. libyaml-devel (CRB) and openssl-devel (AppStream) both resolve on the riscv64 manylinux image, matching upstream's own yum install line. No live Aerospike server in CI; the test command proves the extension compiled and exercises the real C cluster-init code path (the one the patch touches) via a fast, deterministic ConnectionError against a closed port.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aerospike19.2.2Compiles the Aerospike Python client against its bundled aerospike-client-c submodule (C, Apache-2.0). Upstream publishes no riscv64 wheel.
Mirrors upstream's manylinux build path (
build-wheel.bash/_build-wheel-natively.bash).Differs from upstream
dnf installslibyaml-devel/openssl-develon the stock riscv64 image; upstream's custom OpenSSL-baked image has no riscv64 build.Testing
License: OK
Patches
0001-as_arch-portable-pause-fallback.patch- To upstream (not yet submitted).as_arch_pause()is undeclared on riscv64 under-Werror. riscv64-only.Built and imported the wheel on x86_64 locally (sdist -> wheel, no cibuildwheel); extension loads,
client()smoke test passes.