Conversation
luhenry
added a commit
that referenced
this pull request
Sep 27, 2026
Contributor
|
luhenry
marked this pull request as ready for review
September 27, 2026 22:57
luhenry
added a commit
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kaldifst1.8.0Compiles the
_kaldifstpybind11 extension with OpenFST linked in statically. Upstream publishes no riscv64 wheel.Mirrors upstream's
build-wheels-linux.yaml, with the test step oftest-pip-install.yaml.Differs from upstream
KALDIFST_CMAKE_ARGSsets-DPython_EXECUTABLE- pybind11 3.0 otherwise picks the wrong interpreter on cp314t.Testing
License: Wheel statically links OpenFST (Apache-2.0) and pybind11 (BSD-3-Clause); upstream ships no licence text for them, so the build adds it.
Patches
0001-ship-OpenFST-and-pybind11-licences-in-the-wheel-s-dist.patch- To upstream [not yet submitted]. Without it the wheel lacks the OpenFST and pybind11 licence texts. Reproduces on every platform.Built on cp312; 24 passed, 0 skipped.