Conversation
Contributor
|
…ckout uv pip install --no-deps . installed a non-editable copy into site-packages, so jlink's --output (jdk4py.JAVA_HOME) landed there instead of in the src tree that uv build --wheel packages from. The riscv64 wheel came out without java-runtime/ at all (2.7KB), which is why every test hit FileNotFoundError on java-runtime/bin/java.
luhenry
marked this pull request as ready for review
September 28, 2026 19:07
luhenry
added a commit
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jdk4py25.0.2.1Bundles a jlink-trimmed Eclipse Temurin JDK per platform. Upstream publishes no riscv64 wheel.
Mirrors upstream's
build-java-runtime/build-python-wheelcomposite actions.Differs from upstream
actions/setup-javagivenarchitecture: riscv64explicitly - listed as a supported Temurin/linux target but not auto-detected on a self-hosted runnermanylinux_2_39_riscv64- matches this repo's other riscv64 wheels; upstream's own tag table has no riscv64 caseuv pip, notuv run pytestin the checkout -uv runwould reinstall the local project over the wheel under testTesting
tests/test_jdk4py.pyagainst the built wheelLicense: wheel bundles the Eclipse Temurin JDK (GPL-2.0 WITH Classpath-exception-2.0);
jlinkcopies each module's LICENSE intojava-runtime/legal/, same as upstream's own wheels.CI pending.