refactor(setup): drop dead gemini branches from gh-skill install#11
Merged
Conversation
Gemini CLI support was removed in #8, so `gemini` is never detected or added to selected_tools. Remove the now-unreachable `gemini)` cases from gh_skill_agent_id and the gh-skill invocation loop. The remaining `$HOME/.gemini/antigravity-cli/...` paths are Antigravity config and stay. Claude-Session: https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #8 removed Gemini CLI support,
geminiis never detected or added toselected_tools. PR #9's gh-skill code still carried twogemini)branches that can no longer execute:gh_skill_agent_id:gemini) echo "gemini-cli"gemini) configure_gh_skill "gemini" "Gemini CLI"This removes both. The remaining
$HOME/.gemini/antigravity-cli/...references are Antigravity config and are unaffected.bash -n setuppasses.https://claude.ai/code/session_019x6ReGXvRWpC7sF8aum6LR