feat(setup): offer Impeccable design skills install#15
Conversation
After the per-agent installs, prompt to install the Impeccable design skills (impeccable.style) for the selected tools it supports, mirroring the existing gh agent-skill flow. - Map selected tools to Impeccable providers (claude, codex, copilot->github); Antigravity has no provider and is skipped. - Build a de-duplicated --providers list and run `npx impeccable install --providers=<list> --scope=global` on confirm. - Runs via npx with explicit providers/scope, so re-running refreshes an existing install and adds newly-selected agents (idempotent, no separate update branch). - Document the step in the README alongside the gh agent skill.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds optional Impeccable design-skill installation to ChangesImpeccable Skill Installation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit full review |
✅ Action performedFull review finished. |
- Pass "n" to prompt_yes_no so the opt-in Impeccable install defaults to No, matching the documented behavior. - Pre-check npx after opt-in (mirrors the MCP npx guard) so a missing Node.js gives a clear message instead of a misleading install failure.
|
@coderabbitai review |
✅ Action performedReview finished.
|
What
Extends
setupso that, after the per-agent command/skill installs, it offers to install the Impeccable design skills for the selected tools it supports. Modeled on the existingghagent-skill flow.How
impeccable_provider_id()maps this repo's internal tool names to Impeccable--providersids:claude→claude,codex→codex,copilot→github. Antigravity has no Impeccable provider, so it returns empty and is skipped.configure_impeccable_skills()builds a de-duplicated--providerslist from the user's selected tools and, on confirm (default No), runs:Install vs update
It always runs
installrather than a separateupdatecommand. Because it runs vianpx(latest each time) with explicit--providers/--scope(Impeccable's idempotent, scriptable path), re-runningsetuprefreshes an existing install and adds any newly-selected agents. No detect-and-update branch is added, because there is no clean, install-method-agnostic way to detect a per-provider install (e.g. Claude's Impeccable can arrive via/plugin, not npx), and always callinginstallis the better idempotent choice. The prompt wording and README document this.Verification
bash -n setuppasses.setupfunctions touched.