Skip to content

feat(setup): offer Impeccable design skills install#15

Merged
rlorenzo merged 2 commits into
mainfrom
feat/impeccable-skills-setup
Jul 8, 2026
Merged

feat(setup): offer Impeccable design skills install#15
rlorenzo merged 2 commits into
mainfrom
feat/impeccable-skills-setup

Conversation

@rlorenzo

@rlorenzo rlorenzo commented Jul 8, 2026

Copy link
Copy Markdown
Owner

What

Extends setup so that, after the per-agent command/skill installs, it offers to install the Impeccable design skills for the selected tools it supports. Modeled on the existing gh agent-skill flow.

How

  • impeccable_provider_id() maps this repo's internal tool names to Impeccable --providers ids: claude→claude, codex→codex, copilot→github. Antigravity has no Impeccable provider, so it returns empty and is skipped.
  • configure_impeccable_skills() builds a de-duplicated --providers list from the user's selected tools and, on confirm (default No), runs:
    npx impeccable install --providers=<list> --scope=global
    
  • If only Antigravity is selected, the whole section is skipped silently (no empty install command).

Install vs update

It always runs install rather than a separate update command. Because it runs via npx (latest each time) with explicit --providers/--scope (Impeccable's idempotent, scriptable path), re-running setup refreshes an existing install and adds any newly-selected agents. No detect-and-update branch is added, because there is no clean, install-method-agnostic way to detect a per-provider install (e.g. Claude's Impeccable can arrive via /plugin, not npx), and always calling install is the better idempotent choice. The prompt wording and README document this.

Verification

  • bash -n setup passes.
  • Provider-list logic tested standalone across mixed / dedup / Antigravity-only selections.
  • Pre-commit hooks pass: shellcheck, markdownlint, BATS unit tests.
  • No existing tests reference the setup functions touched.

After the per-agent installs, prompt to install the Impeccable design
skills (impeccable.style) for the selected tools it supports, mirroring
the existing gh agent-skill flow.

- Map selected tools to Impeccable providers (claude, codex,
  copilot->github); Antigravity has no provider and is skipped.
- Build a de-duplicated --providers list and run
  `npx impeccable install --providers=<list> --scope=global` on confirm.
- Runs via npx with explicit providers/scope, so re-running refreshes an
  existing install and adds newly-selected agents (idempotent, no
  separate update branch).
- Document the step in the README alongside the gh agent skill.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 85a2d1ae-6bd3-41dd-8f78-2d5ab3e049c3

📥 Commits

Reviewing files that changed from the base of the PR and between 55b9445 and f04469b.

📒 Files selected for processing (1)
  • setup

📝 Walkthrough

Walkthrough

Adds optional Impeccable design-skill installation to setup, wires it into the main install flow, and documents the supported provider behavior and manual commands in README.md.

Changes

Impeccable Skill Installation

Layer / File(s) Summary
Provider mapping and installer function
setup
Adds impeccable_provider_id() for supported tool-to-provider mapping and configure_impeccable_skills() to deduplicate providers, prompt for installation, verify npx, and run npx impeccable install --providers=... --scope=global.
Main flow wiring and documentation
setup, README.md
Calls the Impeccable installer after the gh agent skill step and adds README coverage for supported providers, rerun behavior, Antigravity skipping, and manual install/update commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the new Impeccable install flow added to setup.
Description check ✅ Passed The description matches the PR by explaining the new Impeccable install step and its behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rlorenzo

rlorenzo commented Jul 8, 2026

Copy link
Copy Markdown
Owner Author

@CodeRabbit full review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: badcce44-189d-4c41-8444-e93fc5b6b768

📥 Commits

Reviewing files that changed from the base of the PR and between 04bdf5c and 55b9445.

📒 Files selected for processing (2)
  • README.md
  • setup

Comment thread setup Outdated
Comment thread setup
- Pass "n" to prompt_yes_no so the opt-in Impeccable install defaults to
  No, matching the documented behavior.
- Pre-check npx after opt-in (mirrors the MCP npx guard) so a missing
  Node.js gives a clear message instead of a misleading install failure.
@rlorenzo

rlorenzo commented Jul 8, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@rlorenzo
rlorenzo merged commit ec6cbd0 into main Jul 8, 2026
4 checks passed
@rlorenzo
rlorenzo deleted the feat/impeccable-skills-setup branch July 8, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant