Skip to content

Multiple changes to improve compatiblity with python3 - #133

Open
dilawar wants to merge 8 commits into
robclewley:masterfrom
dilawar:master
Open

Multiple changes to improve compatiblity with python3#133
dilawar wants to merge 8 commits into
robclewley:masterfrom
dilawar:master

Conversation

@dilawar

@dilawar dilawar commented Mar 21, 2018

Copy link
Copy Markdown
  • removed some python3 incompatible statements.
  • Fixed some test scripts.
  • python3 does not accept float as index. Converted indices to int in many places.
  • Minor tweaks to some functions for passing plotting arguments such as color, alpha etc esp. in phaseplane.
  • scipy 1.x compatible (this is from @tkf ).

@Silmathoron

Silmathoron commented Jan 28, 2019

Copy link
Copy Markdown

Hi there, this PR seems very useful (I just had to hack the whole scipy part myself).
Is there something specific preventing it from being merged? (except for the necessary pull from master?)
Is it possible to help with this in any way?

@z2v

z2v commented Jan 29, 2019

Copy link
Copy Markdown
Collaborator

@Silmathoron Most changes have been already merged to master. I'll take a look and cherry-pick whether there are more changes.

@Silmathoron

Copy link
Copy Markdown

Ok, that's good to hear! I was using the PyPi version so I'll probably just switch to master, thank you

@robclewley robclewley mentioned this pull request Jan 2, 2021
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 11.311% when pulling f48b6ef on dilawar:master into 45fc2f1 on robclewley:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants