Skip to content

feat: read sensitive CLI flags from environment variables #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itayvolo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: read sensitive CLI flags from environment variables #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions robusta_krr/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ def run_strategy(
prometheus_auth_header: Optional[str] = typer.Option(
None,
"--prometheus-auth-header",
help="Prometheus authentication header.",
envvar="PROMETHEUS_AUTH_HEADER",
help="Prometheus authentication header. Can also be supplied via the PROMETHEUS_AUTH_HEADER environment variable.",
rich_help_panel="Prometheus Settings",
),
prometheus_other_headers: Optional[List[str]] = typer.Option(
Expand Down Expand Up @@ -162,13 +163,15 @@ def run_strategy(
eks_access_key: Optional[str] = typer.Option(
None,
"--eks-access-key",
help="Sets the access key for eks prometheus connection.",
envvar="EKS_ACCESS_KEY",
help="Sets the access key for eks prometheus connection. Can also be supplied via the EKS_ACCESS_KEY environment variable.",
rich_help_panel="Prometheus EKS Settings",
),
eks_secret_key: Optional[str] = typer.Option(
None,
"--eks-secret-key",
help="Sets the secret key for eks prometheus connection.",
envvar="EKS_SECRET_KEY",
help="Sets the secret key for eks prometheus connection. Can also be supplied via the EKS_SECRET_KEY environment variable.",
rich_help_panel="Prometheus EKS Settings",
),
eks_service_name: Optional[str] = typer.Option(
Expand All @@ -192,7 +195,8 @@ def run_strategy(
coralogix_token: Optional[str] = typer.Option(
None,
"--coralogix-token",
help="Adds the token needed to query Coralogix managed prometheus.",
envvar="CORALOGIX_TOKEN",
help="Adds the token needed to query Coralogix managed prometheus. Can also be supplied via the CORALOGIX_TOKEN environment variable.",
rich_help_panel="Prometheus Coralogix Settings",
),
openshift: bool = typer.Option(
Expand Down Expand Up @@ -311,7 +315,8 @@ def run_strategy(
teams_webhook: Optional[str] = typer.Option(
None,
"--teams-webhook",
help="Microsoft Teams webhook URL to send notifications when files are uploaded to Azure Blob Storage",
envvar="TEAMS_WEBHOOK",
help="Microsoft Teams webhook URL to send notifications when files are uploaded to Azure Blob Storage. Can also be supplied via the TEAMS_WEBHOOK environment variable.",
rich_help_panel="Output Settings",
),
azure_subscription_id: Optional[str] = typer.Option(
Expand Down