Skip to content

docs: close out the 1.1.6 changelog heading - #70

Merged
junkai-roe-ai merged 2 commits into
mainfrom
changelog-close-out-1-1-6
Aug 3, 2026
Merged

docs: close out the 1.1.6 changelog heading#70
junkai-roe-ai merged 2 commits into
mainfrom
changelog-close-out-1-1-6

Conversation

@trial-roe

Copy link
Copy Markdown
Contributor

Why

CHANGELOG.md still files the skip_cache feature under ## Unreleased, but it shipped in 1.1.6 — verified against the tags: git show v1.1.5:src/roe/api/agents.py | grep -c skip_cache0, and the same command at v1.1.617.

This is not a one-off oversight. The release fan-out never touches this file by design — roe-sdk/src/roe_sdk/prepare_target.py: "CHANGELOG.md is intentionally not touched (historical record)". So no release PR has ever closed the heading out, and none will. Left alone, 1.1.7 ships with an empty changelog too.

The only open PR that touches CHANGELOG.md is #66, which closes the heading out as 1.2.0 — the wrong version (1.2.0 was a roe-golang-only bump, and this repo's live line is 1.1.x continuing to 1.1.7 in #69). #66 should be closed rather than merged: its reason to exist was deleted upstream by roe-main 3ae83b888 ("Version SDK release targets independently", #3747), which removed the cross-repo version lockstep guard. This PR salvages the one genuinely useful line from it, at the correct version.

What

One line: ## Unreleased## 1.1.6.

No version file changes, so tag-on-release-merge.yml does not fire and nothing publishes.

The same fix is up for roe-typescript, whose CHANGELOG.md has the identical stale heading over its skipCache entry.

🤖 Generated with Claude Code

trial-roe and others added 2 commits August 2, 2026 11:36
skip_cache shipped in 1.1.6 (absent at tag v1.1.5, present at v1.1.6) but
CHANGELOG.md still files it under Unreleased. The release fan-out never
touches this file — prepare_target.py leaves it alone as a historical
record — so no release PR has closed it out and none will.

Salvaged from #66, which closes the same heading out as 1.2.0. That
version is wrong for this repo and #66 is otherwise obsolete: roe-main
3ae83b888 (#3747) removed the cross-repo version lockstep guard it
existed to satisfy.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The hand-written response fixtures behind the connections and agents
wrapper transport tests have drifted from the generated models. Three
roe-main changes added read-only-but-required serializer fields that
nothing downstream backfilled:

  #3758  dynamic_inputs, dynamic_input_test_disabled_reason
  #3837  credentials_configured
  #3701  BaseAgent.updated_at

Connection.from_dict / BaseAgent.from_dict pop required keys with no
default, so each addition turned into a KeyError. main has been red on
these same four tests since #68 merged on 2026-07-29 (run 30493974267);
this PR did not introduce the failure, it only changed which missing key
raises first, because credentials_configured is popped before
dynamic_inputs.

Fixing it in this branch rather than separately so #69 merges green —
publish.yml is `on: push tags v*` with no test step and no needs: on CI,
so a red merge would tag v1.1.7 and ship an untested tree to PyPI.

Only the response fixtures change. The expected request-body literal in
test_connection_create_... is deliberately untouched: these are read-only
fields the client never sends. tests/ is outside the python target's
diff_paths and outside check-codegen-drift, so the fan-out will not
clobber this.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 2, 2026

Copy link
Copy Markdown

Greptile Summary

This update moves the existing skip_cache release notes from the unreleased section into version 1.1.6.

The checked release metadata and tag context match the new heading, the feature notes remain in place, and the resulting changelog structure is valid.

Confidence Score: 5/5

T-Rex T-Rex Logs

What T-Rex did

  • I ran the changelog heading validator against the base commit 435bcb5 and confirmed the Markdown structure check passed.
  • I ran the same validator at HEAD, where the heading sits under 1.1.6, and it matched the project version and v1.1.6 tag, retained the skip_cache=True notes, and passed the Markdown structure check.
  • I captured the exact validator source and verified the before and after states, showing that before output the base had Unreleased with skip_cache=True and structurally valid, and after output HEAD had 1.1.6, matched the version and tag, retained skip_cache=True, and remained structurally valid.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "docs: close out the 1.1.6 changelog head..." | Re-trigger Greptile

@trial-roe

Copy link
Copy Markdown
Contributor Author

Added the stale-fixture commit here as well (cherry-pick of 24df7a6, the same commit on #69's branch) so this PR is green on its own instead of inheriting main's red test job.

Context: main has been failing these four tests since #68 merged on 2026-07-29 (run 30493974267) — KeyError: 'dynamic_inputs' / 'updated_at', from hand-written response fixtures that never picked up newly-required serializer fields. Any PR branched off main inherits it, including a one-line changelog edit.

The commit is byte-identical on both branches, so either merge order is fine — whichever lands second is a no-op for those two files. Merging this one also un-reds main immediately, without waiting on the 1.1.7 release.

@junkai-roe-ai
junkai-roe-ai merged commit 1fa165d into main Aug 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants