Skip to content

Implement resend_webhook on the agent jobs facade - #72

Merged
Chen-ROE merged 3 commits into
mainfrom
chen/agent-jobs-resend-webhook-facade
Aug 18, 2026
Merged

Implement resend_webhook on the agent jobs facade#72
Chen-ROE merged 3 commits into
mainfrom
chen/agent-jobs-resend-webhook-facade

Conversation

@Chen-ROE

Copy link
Copy Markdown
Contributor

The v1.0.93 release (#71) shipped the generated endpoint module and an SDK_EXAMPLES entry for client.agents.jobs.resend_webhook, but the hand-written AgentJobsAPI facade has no such method — following the documented example raises AttributeError before any request is sent.

This adds the facade method, mirroring cancel_all: it calls the generated agents_jobs_webhook_resend_create endpoint and returns the AgentJobWebhookResendResponse model (queued reports how many deliveries were queued; zero means the agent has no active webhook).

Flagged by Greptile on #71, which had already merged by the time the fix was ready — hence this follow-up against main rather than a push to the release branch.

Test Plan

  • python -m py_compile on the changed module
  • CI (lint / test / codegen-drift) on this PR

🤖 Generated with Claude Code

The generated endpoint module and the SDK examples both reference
client.agents.jobs.resend_webhook, but the hand-written facade had no such
method, so following the documented example raised AttributeError before any
request was sent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds AgentJobsAPI.resend_webhook, forwarding the job and organization IDs to the generated resend endpoint and parsing its queued-delivery response.

  • Adds the generated endpoint import and response model annotation.
  • Adds the hand-written jobs facade method documented by the preceding release.
  • The response model is imported from the wrong generated module, breaking normal SDK imports.

Confidence Score: 4/5

The PR is not safe to merge until the response model import is corrected, because normal SDK imports currently fail.

The facade call itself matches the generated endpoint contract, but module initialization imports AgentJobWebhookResendResponse from a module that does not export it, causing an immediate ImportError.

Files Needing Attention: src/roe/api/agents.py

Important Files Changed

Filename Overview
src/roe/api/agents.py Adds the resend-webhook facade with request handling consistent with sibling methods, but its response-model import targets the wrong module and breaks SDK imports.

Fix all with Greploop Fix All in Claude Code

Reviews (1): Last reviewed commit: "Implement resend_webhook on the agent jo..." | Re-trigger Greptile

Comment thread src/roe/api/agents.py
Chen-ROE and others added 2 commits August 18, 2026 00:24
The model lives in agent_job_webhook_resend_response, not alongside
AgentJobCancelAllResponse; importing it from the wrong module broke every test
that imports roe.api.agents. Adds the transport test that would have caught it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The endpoint takes an optional webhook_id to reach one subscription instead of
every one.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Chen-ROE
Chen-ROE merged commit a83f6dc into main Aug 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants