Implement resend_webhook on the agent jobs facade - #72
Merged
Conversation
The generated endpoint module and the SDK examples both reference client.agents.jobs.resend_webhook, but the hand-written facade had no such method, so following the documented example raised AttributeError before any request was sent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThe PR adds
Confidence Score: 4/5The PR is not safe to merge until the response model import is corrected, because normal SDK imports currently fail. The facade call itself matches the generated endpoint contract, but module initialization imports Files Needing Attention: src/roe/api/agents.py Important Files Changed
Reviews (1): Last reviewed commit: "Implement resend_webhook on the agent jo..." | Re-trigger Greptile |
The model lives in agent_job_webhook_resend_response, not alongside AgentJobCancelAllResponse; importing it from the wrong module broke every test that imports roe.api.agents. Adds the transport test that would have caught it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The endpoint takes an optional webhook_id to reach one subscription instead of every one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
junkai-roe-ai
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.93 release (#71) shipped the generated endpoint module and an SDK_EXAMPLES entry for
client.agents.jobs.resend_webhook, but the hand-writtenAgentJobsAPIfacade has no such method — following the documented example raisesAttributeErrorbefore any request is sent.This adds the facade method, mirroring
cancel_all: it calls the generatedagents_jobs_webhook_resend_createendpoint and returns theAgentJobWebhookResendResponsemodel (queuedreports how many deliveries were queued; zero means the agent has no active webhook).Flagged by Greptile on #71, which had already merged by the time the fix was ready — hence this follow-up against main rather than a push to the release branch.
Test Plan
python -m py_compileon the changed module🤖 Generated with Claude Code