Skip to content

Fix search input focus and shortcuts - #187

Closed
rsheyd wants to merge 1 commit into
romaintb:mainfrom
rsheyd:codex/search-input-footer
Closed

Fix search input focus and shortcuts#187
rsheyd wants to merge 1 commit into
romaintb:mainfrom
rsheyd:codex/search-input-footer

Conversation

@rsheyd

@rsheyd rsheyd commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What changed

  • keep every letter available for typing while the search query has focus
  • move focus into search results with the Down arrow and visibly highlight the selected task
  • enable result-only shortcuts after focus moves to the results (j/k, arrow navigation, and t for Today)
  • add a context-sensitive shortcut bar at the bottom of the search dialog
  • leave Enter without an action
  • document the search focus model and add regression coverage

Why

Search result shortcuts were intercepting letters such as k, which prevented users from entering ordinary search terms. Separating query focus from result focus makes typing unambiguous while preserving useful task shortcuts after the user deliberately navigates into the results.

Validation

  • cargo fmt --check
  • cargo test dialog_component (5 passed)
  • git diff --check
  • cargo test reaches the pre-existing tests/storage/db.rs::test_local_storage_creation failure on clean main; no storage code is changed here

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rsheyd, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 007fdf91-0a89-4bba-a07b-9378c8cb9eb3

📥 Commits

Reviewing files that changed from the base of the PR and between 81c680e and c3776c7.

📒 Files selected for processing (4)
  • docs/KEYBOARD_SHORTCUTS.md
  • src/ui/components/dialog_component.rs
  • src/ui/components/dialogs/mod.rs
  • tests/ui/components/dialog_component.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rsheyd

rsheyd commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by consolidated upstream PR #188, which includes this search-input focus work together with the UI baseline, cache lifecycle, typed operations, and versioned snapshots. Please review and test #188 instead.

@rsheyd rsheyd closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant