Rectangular Page Indicator#50
Open
StuStirling wants to merge 19 commits intoromandanylyk:devfrom
Open
Conversation
Update README.md
A lot of the animation types need implementing. So far, the animation types that work are as follows: - Color - Drop (without scale) - Slide - Swap The added attributes in XML are: + piv_rectWidth + piv_rectHeight + piv_cornerRadius
Closed
|
Is this still under consideration? Would love the chance to customize the indicator beyond circles. |
msaviczki-dev
approved these changes
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial effort at adding support for a rectangular indicator rather than just circular. Some more work could be done to improve the code and potentially allow the ability to put in all sorts of shapes.
Animations of type
WormandThinWormstill need to be implemented for rectangular indicators.