handle missing ScanPath kwargs with fallback values and improve error handling in get_scan_info() - #110
Open
ArthurLuciani2 wants to merge 1 commit into
Open
handle missing ScanPath kwargs with fallback values and improve error handling in get_scan_info()#110ArthurLuciani2 wants to merge 1 commit into
ArthurLuciani2 wants to merge 1 commit into
Conversation
… handling in get_scan_info()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
get_scan_info()assumes that a scan necessarily has a 'Circle' path which is not always True. This present fix just catches KeyError exceptions when the path is not a circle but it is not in my opinion a good long term solution.Truth is, I think this workspace "patch" should not be in plantdb but in P3DX (for which it is meant). This makes plantdb much less flexible in what a scan can be and can contain.