[RF][HS3] Fixed snapshot filter, unbinned data edges, zero yield bins#22073
Merged
guitargeek merged 3 commits intoroot-project:masterfrom May 8, 2026
Merged
[RF][HS3] Fixed snapshot filter, unbinned data edges, zero yield bins#22073guitargeek merged 3 commits intoroot-project:masterfrom
guitargeek merged 3 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 10h 0m 20s ⏱️ For more details on these failures, see this check. Results for commit 5f6bedc. ♻️ This comment has been updated with latest results. |
* Snapshot export no longer filters global observables
* Axes of unbinned datasets now contain information on the range of
observables
* Added a fail safe for histfactory bins with zero yield and non-zero
error
guitargeek
changed the title
guitargeek
approved these changes
May 8, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much! I also have added a test and some general improvements.
Contributor
|
/backport to 6.40 |
|
Preparing to backport PR #22073 to branch 6.40 requested by guitargeek |
|
This PR has been backported to branch 6.40: #22184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixed snapshot filter, unbinned data edges, zero yield bins
Changes or fixes:
Checklist:
@cburgard