Silence TMVA SOFIE tutorial warnings from third party libraries#22144
Open
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Open
Silence TMVA SOFIE tutorial warnings from third party libraries#22144guitargeek wants to merge 3 commits intoroot-project:masterfrom
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Conversation
User-facing code like tutorials should be nicely formatted, in particular avoiding non-standard indentations with three spaces that can annoy users when copy-pasting code.
guitargeek
force-pushed
the
tmva_tutorial_warnings
branch
from
a4c3694 to
35ef191
Compare
Keras and PyTorch still cause some warnings in a few places where they use deprecated features from their dependencies. We need a mechanism to silence these warnings to that our tests will run with warnings as errors, while also making sure we catch when the warnings don't happen anymore, so we can remove the boilerplate code for warnings silencing.
In particular, replace `raiseError` which is only available in pytest fixtures.
guitargeek
force-pushed
the
tmva_tutorial_warnings
branch
from
35ef191 to
72db81c
Compare
Test Results 22 files 22 suites 3d 10h 16m 2s ⏱️ Results for commit 72db81c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keras and PyTorch still cause some warnings in a few places where they use deprecated features from their dependencies. We need a mechanism to silence these warnings to that our tests will run with warnings as errors, while also making sure we catch when the warnings don't happen anymore, so we can remove the boilerplate code for warnings silencing.
With this change, we are working towards: