[tree] In TBasket/TBranch, error out if reading oob in the streamer#22165
Open
silverweed wants to merge 2 commits intoroot-project:masterfrom
Open
[tree] In TBasket/TBranch, error out if reading oob in the streamer#22165silverweed wants to merge 2 commits intoroot-project:masterfrom
silverweed wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 9h 30m 52s ⏱️ Results for commit bf379ae. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
May 7, 2026
| fBasketEntry = new Long64_t[fMaxBaskets]; | ||
| b >> n; | ||
| if (n > fMaxBaskets) { | ||
| Error("Streamer", "Inconsistent length of the entry buffer. Refusing to deserialize."); |
Member
There was a problem hiding this comment.
Suggested change
| Error("Streamer", "Inconsistent length of the entry buffer. Refusing to deserialize."); | |
| Error("Streamer", "Inconsistent number of baskets. Refusing to deserialize. Read %d for an expected maximum of %d.", n, fMaxBaskets); |
pcanal
reviewed
May 7, 2026
| } | ||
| if (!mustGenerateOffsets && flag && (flag % 10 != 2)) { | ||
| if (fNevBuf > fNevBufSize) { | ||
| Error("Streamer", "Inconsistent length of the entry buffer. Refusing to deserialize."); |
Member
There was a problem hiding this comment.
Could we make the message more explicit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
fNevBufSizeand pass nullptr toReadArrayor if we should rather check that they matchChecklist:
This PR fixes #22164