[df] Avoid registering any TFile#22168
Open
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Open
[df] Avoid registering any TFile#22168vepadulano wants to merge 1 commit intoroot-project:masterfrom
vepadulano wants to merge 1 commit intoroot-project:masterfrom
Conversation
silverweed
reviewed
May 7, 2026
| { | ||
| fOutputFile.reset( | ||
| TFile::Open(fFileName.c_str(), fOptions.fMode.c_str(), /*ftitle=*/"", GetSnapshotCompressionSettings(fOptions))); | ||
| fOutputFile.reset(TFile::Open(fFileName.c_str(), (fOptions.fMode + "_WITHOUT_GLOBALREGISTRATION").c_str(), |
Contributor
There was a problem hiding this comment.
Do we ever risk appending _WITHOUT_GLOBALREGISTRATION twice? Most of the TFile code seems to cope with it fine, but not all of it (e.g.
Line 3909 in b790144
Test Results 22 files 22 suites 3d 8h 51m 38s ⏱️ For more details on these failures, see this check. Results for commit 733248e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.