[core] Fix UB in frombuf/tobuf#22176
Open
silverweed wants to merge 1 commit intoroot-project:masterfrom
Open
Conversation
Using a union to get around strict type aliasing is not allowed. memcpy must be used instead.
Test Results 22 files 22 suites 3d 13h 20m 27s ⏱️ For more details on these failures, see this check. Results for commit 99bff2a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup: using a union to get around strict type aliasing is not allowed.
memcpymust be used instead.Similarly, replace pointer casts+read with memcpy.