[reve] Add chek for empty REveGeoPolyShape and REvePolygonSetProjected#22198
Open
alja wants to merge 1 commit intoroot-project:masterfrom
Open
[reve] Add chek for empty REveGeoPolyShape and REvePolygonSetProjected#22198alja wants to merge 1 commit intoroot-project:masterfrom
alja wants to merge 1 commit intoroot-project:masterfrom
Conversation
Contributor
Author
|
Below is the stack when importing the shape extract with an empty shape: |
Contributor
Author
|
@linev Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases of REveGeoShapeExtract, an empty REveGeoShape holder is created for the directory structure.
Example:
For this case, EveGlu::TriangleCollector::ProcessData() needs the check before accessing the first element.