Fixes in rmw_wait (backport #895) - #916
Merged
Merged
Conversation
* fix: Fix race condition when untriggering guard conditions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * fix: return `RMW_RET_OK` whenever an active element is returned Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * style: uncrustify Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 83471d4)
Merged
|
Pulls: #916
|
ahcorde
approved these changes
Sep 9, 2026
Contributor
|
Pulls: #916
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes two things in
rmw_wait:RMW_RET_TIMEOUTbeing returned when an element becomes ready after the wait set timed outIs this user-facing behavior change?
Did you use Generative AI?
Additional Information
Related regression test in ros2/rmw_implementation#280
This is an automatic backport of pull request #895 done by Mergify.