Conversation
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
kscottz
approved these changes
Sep 18, 2026
kscottz
left a comment
kscottz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. 🫡
Thanks for the PR! Really appreciate you documenting this great new feature.
Collaborator
|
@ahcorde can I get a quick second review and smash that merge button? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to ros2/ros2cli#1262
cc @fujitatomoya
Did you use Generative AI?
Yes, Codex 5.6 Sol, I ran the demo and provided the output to AI
Additional Information
This should not be backported