Mention Windows build config ABI incompatibility (backport #7192) - #7199
Open
mergify[bot] wants to merge 1 commit into
Open
mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
We stopped producing debug Windows binaries some time ago, only leaving release binaries. On Windows, for ABI compatibility, this means anything downstream must also be built in release mode. Mention it explicitly here. And mention having to build ROS 2 from source to use another build config. This should be backported to all distros that only have Windows release binaries. Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 0d14d8e) # Conflicts: # source/Get-Started/Installation/Windows-Install-Binary.rst
Contributor
Author
|
Cherry-pick of 0d14d8e has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We stopped producing debug Windows binaries some time ago, only leaving release binaries. On Windows, for ABI compatibility, this means anything downstream must also be built in Release or RelWithDebInfo mode. Mention it explicitly here. And mention having to build ROS 2 from source to use another build config.
See: https://discourse.openrobotics.org/t/ros-2-windows-ci-on-github-actions-current-options-and-a-pixi-based-pattern/57736/6
Did you use Generative AI?
No
Additional Information
This should be backported to all distros that only have Windows release binaries, which is all of them, even though we've stopped producing binaries for distros targeting Windows 10, since it is EOL. We can still backport this in case someone is using one of those distros' last Windows binaries.
This is an automatic backport of pull request #7192 done by Mergify.