Add system check for LifecycleModelMixin coming after models.Model - #187
Open
juneja-varun wants to merge 1 commit into
Open
Add system check for LifecycleModelMixin coming after models.Model#187juneja-varun wants to merge 1 commit into
juneja-varun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149.
If `models.Model` comes before `LifecycleModelMixin` in a model's base classes, `Model.save()` wins the MRO and runs instead of the mixin's - so every lifecycle hook on that model silently never fires. No error, no warning, hooks just don't run. Confirmed this live: a model with the bases swapped saves fine, but a `BEFORE_SAVE` hook that should flip a field never does.
Added a new check (`django_lifecycle.E002`) alongside the existing one, following the direction discussed in #147 - flags any model using `LifecycleModelMixin` where it doesn't come before `models.Model` in the MRO, so this fails loudly (via `manage.py check`) instead of silently.