feat(carousel): add fade transition option#159
Open
danish17 wants to merge 4 commits into
Open
Conversation
Needed to implement the fade transition option for the carousel block.
Adds a Transition setting (Slide | Fade) backed by embla-carousel-fade, wired the same way as the existing Autoplay plugin. Fade forces align/containScroll/dragFree/slidesToScroll to compatible values under the hood and hides the now-irrelevant inspector controls. Editor canvas loads the same plugin so the fade preview matches the frontend. Includes a deprecated save() entry so posts saved before this change keep validating.
Covers the transition attribute/context shape, the Fade plugin being pushed only when transition is fade, and the inspector hiding slide-only controls when fade is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embla-carousel-fade, wired the same way as the existing Autoplay plugin.align/containScroll/dragFree/slidesToScrollto compatible values under the hood and hides the now-irrelevant inspector controls when active.deprecatedsave() entry so posts saved before this change keep validating.Test plan
npm run lint:jsnpm run lint:js:typesnpm run test:js(132 passing)npm run build