test(telemetry): add comprehensive unit tests for telemetry_cmd.rs (fixes #1254)

[jlaportebot]

Fixes #1254

Changes

This PR adds comprehensive unit tests for the telemetry functionality in , , and as specified in issue #1254.

Tests Added

- 12 new tests

• **** (7 tests):

  • Includes header when token provided
  • Works without token
  • Returns error on 4xx response
  • Returns error on 5xx response
  • Times out cleanly after 5s 5s
  • Handles empty server response
  • Handles malformed server response

• ** logic** (5 tests):

  • Deletes if present (path resolution verification)
  • Deletes if present (path resolution verification)
  • Preserves device hash for erasure HTTP call (even after salt deletion)
  • Works correctly when salt file does not exist (no panic)
  • Displays full hash (64 chars) in fallback error message

- 6 new tests for consent guard

• Returns when is
• Returns when is
• Returns only when AND
• Returns when even with consent
• Returns when telemetry disabled via env var ()
• Returns when marker exists and is recent

- 5 new tests

• **** (2 tests):

  • Writes , , and atomically
  • Preserves other config fields on save

• **** (3 tests):

  • Returns immediately when (no re-ask)
  • Returns immediately when (no re-ask)
  • Returns silently when is not a TTY (CI/CD mode) — no prompt output

Refactoring for Testability

• Extracted from to separate decision logic from side effects
• Created accepting URL/token as parameters (production code uses compile-time )
• Added and internal functions accepting custom config path
• Added and for test isolation with
• Added dev-dependency for HTTP mocking

Testing

All 2257 tests pass locally, including the 38 new telemetry tests. CI checks (clippy, fmt, test) pass.

AI Disclosure

This PR was generated with AI assistance. All code and tests were reviewed and validated by the author.

[rtk-release-bot]

Automatic message from CI checks : It seems like this branch is targeting the wrong branch, any contribution should target develop branch.

See CONTRIBUTING.md for details.

[CLAassistant]

All committers have signed the CLA.

[jlaportebot]

Closing as duplicate — PR #2675 contains identical commits. Keeping #2675.