Handle case insensitive match for Time.{iso8601,xmlschema,rfc3339} - #75
Merged
jeremyevans merged 1 commit intoAug 2, 2026
Merged
Conversation
The T and Z in the regular expressions are case insensitive, but Time.new on Ruby 3.2+ does not support the lowercase versions. Arguably, lower case t and z shouldn't be allowed, but they were historically supported. Time.rfc3339 is a new method, so backwards compatibility is not technically necessary, but the ActiveSupport Time.rfc3339 method supports the lower case versions. The optimization in b8c50d2 broke backwards compatibility for lower case t and z, since it started calling Time.new. While I don't necessarily have a problem with breaking backwards compatibility in order to improve standards conformance (depending on the case), I think the decision should be deliberate and not accidental due to an optimization. The fix is trivial, and doesn't cause an additional allocation, since strip already returns a fresh string.
byroot
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The T and Z in the regular expressions are case insensitive, but Time.new on Ruby 3.2+ does not support the lowercase versions. Arguably, lower case t and z shouldn't be allowed, but they were historically supported. Time.rfc3339 is a new method, so backwards compatibility is not technically necessary, but the ActiveSupport Time.rfc3339 method supports the lower case versions.
The optimization in b8c50d2 broke backwards compatibility for lower case t and z, since it started calling Time.new.
While I don't necessarily have a problem with breaking backwards compatibility in order to improve standards conformance (depending on the case), I think the decision should be deliberate and not accidental due to an optimization.
The fix is trivial, and doesn't cause an additional allocation, since strip already returns a fresh string.